unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 37182@debbugs.gnu.org, Wolfgang.Scherer@gmx.de
Subject: bug#37182: Acknowledgement (24.5; 24.5.1: C-u vc-dir-mark-all-files should not mark directories)
Date: Wed, 05 Feb 2020 16:24:44 +0200	[thread overview]
Message-ID: <837e11glhv.fsf@gnu.org> (raw)
In-Reply-To: <06656381-cf6d-f6d9-6894-974d5a9cda9a@yandex.ru> (message from Dmitry Gutov on Wed, 5 Feb 2020 03:28:24 +0300)

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Wed, 5 Feb 2020 03:28:24 +0300
> 
> On 27.08.2019 2:06, Wolfgang Scherer wrote:
> >   	(ewoc-map
> >   	 (lambda (filearg)
> > -	   (unless (vc-dir-fileinfo->marked filearg)
> > +	   (unless (or (vc-dir-fileinfo->directory filearg)
> > +		       (vc-dir-fileinfo->marked filearg))
> >   	     (setf (vc-dir-fileinfo->marked filearg) t)
> >   	     t))
> >   	 vc-ewoc))
> 
> LGTM (works, too).
> 
> Eli, this okay for emacs-27?

Yes, but please also fix the doc string to clearly say what happens
with directories.

Thanks.





  reply	other threads:[~2020-02-05 14:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-25 17:54 bug#37182: 24.5; 24.5.1: C-u vc-dir-mark-all-files should not mark directories Wolfgang Scherer
     [not found] ` <handler.37182.B.156675851429203.ack@debbugs.gnu.org>
2019-08-26 23:06   ` bug#37182: Acknowledgement (24.5; 24.5.1: C-u vc-dir-mark-all-files should not mark directories) Wolfgang Scherer
2020-02-05  0:28     ` Dmitry Gutov
2020-02-05 14:24       ` Eli Zaretskii [this message]
2020-02-11 22:31         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837e11glhv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37182@debbugs.gnu.org \
    --cc=Wolfgang.Scherer@gmx.de \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).