From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Fri, 07 Feb 2020 11:26:54 +0200 Message-ID: <837e0yg335.fsf@gnu.org> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="96515"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 07 10:28:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1izzvo-000Oy8-Gu for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Feb 2020 10:28:12 +0100 Original-Received: from localhost ([::1]:52684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izzvn-0004LG-FC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Feb 2020 04:28:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35660) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izzvf-0004JT-No for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 04:28:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izzve-0006QU-Pe for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 04:28:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42921) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1izzve-0006QN-MM for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 04:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1izzve-0000w9-Gm for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 04:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Feb 2020 09:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.15810676453502 (code B ref 39452); Fri, 07 Feb 2020 09:28:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 7 Feb 2020 09:27:25 +0000 Original-Received: from localhost ([127.0.0.1]:48894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izzv3-0000uN-Ge for submit@debbugs.gnu.org; Fri, 07 Feb 2020 04:27:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1izzv1-0000u0-FM for 39452@debbugs.gnu.org; Fri, 07 Feb 2020 04:27:24 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1izzuv-0005QJ-TO; Fri, 07 Feb 2020 04:27:17 -0500 Original-Received: from [176.228.60.248] (port=2261 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1izzuu-0002Jt-Lz; Fri, 07 Feb 2020 04:27:17 -0500 In-reply-to: <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> (message from Dmitry Gutov on Fri, 7 Feb 2020 11:43:36 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175742 Archived-At: > Cc: 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de > From: Dmitry Gutov > Date: Fri, 7 Feb 2020 11:43:36 +0300 > > On 07.02.2020 10:57, Eli Zaretskii wrote: > >> From: Dmitry Gutov > >> Date: Fri, 7 Feb 2020 02:00:38 +0300 > >> > >> I wonder how many other backends commands are broken for files like > >> that: we basically never shell-quote file names. > > > > Whenever we run commands via the shell, the prudent thing is to always > > quote file names (and in general any argument that might include > > wildcard characters). One advantage of call-process is that you don't > > have to do that. > > It's not so simple. FILE already goes through call-process. But Git > expects a pathspec, not just a file name. So if it's a glob, it is expanded. What I wrote was a response to your "we basically never quote". Let me correct my perhaps too-general response by saying "the prudent thing is to always quote file names, unless the command expects a wildcard in that argument".