From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: 40529@debbugs.gnu.org, nadiasggeb001@gmail.com
Subject: bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error
Date: Sun, 12 Apr 2020 16:43:17 +0300 [thread overview]
Message-ID: <837dyklszu.fsf@gnu.org> (raw)
In-Reply-To: <CALDnm52S1EAwuKsXXX+n09X1TbX24UtTz8X1xJ6aA3msZS_XdQ@mail.gmail.com> (message from João Távora on Sun, 12 Apr 2020 13:22:34 +0100)
> From: João Távora <joaotavora@gmail.com>
> Date: Sun, 12 Apr 2020 13:22:34 +0100
> Cc: Aidan Beggs <nadiasggeb001@gmail.com>, 40529@debbugs.gnu.org
>
> But after some analysis, I think it is tabulated-list-mode, or rather
> its recent adaptation to display-line-numbers-mode, which is in the
> wrong here. It used to be that using a mode derived from
> tabulated-list-mode didn't immediately force a request for refreshing its
> rows. After display-line-numbers-mode came along, that ceased to be
> true in some situations.
>
> Reading the special code in tabulated-list-mode concerned with line
> numbers, the latter seem to affect only the header line, not the
> buffer's contents. So this seems to be the correct fix:
I don't remember all the callers/users of tabulated-list-mode, so I
cannot be sure your patch is correct. (Why only update the header?
the columns below the header need to be realigned as well, no? See
tabulated-line-print-col, for example.)
However, if you are convinced it's TRT, I'm okay with doing that on
master. On the release branch, please try to find a solution that is
not in tabulated-list-mode, but in Flymake.
TIA
next prev parent reply other threads:[~2020-04-12 13:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 20:55 bug#40529: 26.3; global-display-line-numbers-mode and flymake-show-diagnostics-buffer error Aidan Beggs
2020-04-10 6:30 ` Eli Zaretskii
2020-04-10 11:50 ` João Távora
2020-04-10 12:16 ` Eli Zaretskii
2020-04-10 14:38 ` João Távora
2020-04-10 15:50 ` Eli Zaretskii
2020-04-10 16:09 ` João Távora
2020-04-10 16:16 ` João Távora
2020-04-12 12:22 ` João Távora
2020-04-12 13:43 ` Eli Zaretskii [this message]
2020-04-12 14:13 ` João Távora
2020-04-12 14:42 ` Eli Zaretskii
2020-04-12 16:58 ` João Távora
2020-04-12 17:15 ` Eli Zaretskii
2020-04-12 20:45 ` Aidan Beggs
2020-04-13 5:03 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837dyklszu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=40529@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=nadiasggeb001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).