From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41646: Startup in Windows is very slow when load-path contains many entries. Date: Fri, 14 Aug 2020 22:07:15 +0300 Message-ID: <837du1kpwc.fsf@gnu.org> References: <83y2p6epp5.fsf@gnu.org> <83pnaieme8.fsf@gnu.org> <83eeqydxdn.fsf@gnu.org> <87r1s92ld9.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33894"; mail-complaints-to="usenet@ciao.gmane.io" Cc: nicolasbertolo@gmail.com, 41646@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 14 21:08:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6f3i-0008ht-75 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 21:08:10 +0200 Original-Received: from localhost ([::1]:41902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6f3h-000622-6j for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 15:08:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6f3b-00061v-44 for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 15:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6f3a-0002iT-Pm for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 15:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6f3a-0000Lq-I9 for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 15:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 19:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41646 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41646-submit@debbugs.gnu.org id=B41646.15974320511313 (code B ref 41646); Fri, 14 Aug 2020 19:08:02 +0000 Original-Received: (at 41646) by debbugs.gnu.org; 14 Aug 2020 19:07:31 +0000 Original-Received: from localhost ([127.0.0.1]:53881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6f35-0000L7-2T for submit@debbugs.gnu.org; Fri, 14 Aug 2020 15:07:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6f30-0000Kr-An for 41646@debbugs.gnu.org; Fri, 14 Aug 2020 15:07:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35981) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6f2v-0002cW-3H; Fri, 14 Aug 2020 15:07:21 -0400 Original-Received: from [176.228.60.248] (port=4334 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6f2u-0005YN-Au; Fri, 14 Aug 2020 15:07:20 -0400 In-Reply-To: <87r1s92ld9.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 14 Aug 2020 19:22:26 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185156 Archived-At: > From: Lars Ingebrigtsen > Cc: Eli Zaretskii , 41646@debbugs.gnu.org > Date: Fri, 14 Aug 2020 19:22:26 +0200 > > > That was a very good idea. The attached patch reduces time spent > > in openp() during startup by 5 seconds, or 15%. > > That's a huge speed-up indeed. > > [...] > > > - fd = emacs_open (pfn, O_RDONLY, 0); > > + /* In some systems (like Windows) finding out if a > > + file exists is cheaper to do than actually opening > > + it. Only open the file when we are sure that it > > + exists. */ > > +#ifdef WINDOWSNT > > + if (faccessat (AT_FDCWD, pfn, R_OK, AT_EACCESS)) > > + fd = -1; > > + else > > +#endif > > + fd = emacs_open (pfn, O_RDONLY, 0); > > + > > This is a Windows-specific patch, so I have no opinion on it. Eli? > Does this make sense to you? Not sure. 15% sounds too little for having OS-specific code in that place. I hoped it will be much more.