From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Date: Sat, 29 Aug 2020 09:54:13 +0300 Message-ID: <837dtiymay.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35567"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com To: Mauro Aranda , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 29 08:55:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kBulZ-00097V-KA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Aug 2020 08:55:09 +0200 Original-Received: from localhost ([::1]:36110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBulY-0005fR-3b for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Aug 2020 02:55:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBulS-0005fL-AF for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 02:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kBulS-0001Vd-0l for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 02:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kBulR-0008QC-W2 for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 02:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Aug 2020 06:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41145 X-GNU-PR-Package: emacs Original-Received: via spool by 41145-submit@debbugs.gnu.org id=B41145.159868406932328 (code B ref 41145); Sat, 29 Aug 2020 06:55:01 +0000 Original-Received: (at 41145) by debbugs.gnu.org; 29 Aug 2020 06:54:29 +0000 Original-Received: from localhost ([127.0.0.1]:47860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBukv-0008PL-55 for submit@debbugs.gnu.org; Sat, 29 Aug 2020 02:54:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kBukt-0008P3-3o for 41145@debbugs.gnu.org; Sat, 29 Aug 2020 02:54:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49864) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBukn-0001Tg-P1; Sat, 29 Aug 2020 02:54:21 -0400 Original-Received: from [176.228.60.248] (port=1952 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kBukm-0007kW-KS; Sat, 29 Aug 2020 02:54:20 -0400 In-Reply-To: (message from Mauro Aranda on Fri, 28 Aug 2020 11:48:57 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186634 Archived-At: > From: Mauro Aranda > Date: Fri, 28 Aug 2020 11:48:57 -0300 > Cc: Philipp Stephani , 41145@debbugs.gnu.org > > Eli Zaretskii writes: > > >> From: Philipp Stephani > >> Date: Sat, 09 May 2020 10:30:13 +0200 > >> > >> The two issues here are: > >> > >> 1. "Group definition missing." It looks like customizing this group > >> should load `display-fill-column-indicator-mode', which defines this > >> group, or the group definition should be in cus-start.el. > > The same seems to work for display-line-numbers, and I don't think I > > see the crucial difference. > > I did some debugging and found that the difference is that there are no > custom options or faces defined in display-fill-column-indicator.el: > fill-column-indicator is in faces.el and > display-fill-column-indicator, display-fill-column-indicator-character > and display-fill-column-indicator-column are in xdisp.c > > custom-make-dependencies doesn't go through faces.el, since it's > preloaded, so it doesn't record the custom-where property into > fill-column-indicator. > And since cus-dep.el doesn't require cus-start, fill-column-indicator is > the only member of the custom-group property of > display-fill-column-indicator, so there is no way > custom-make-dependencies will record the custom-where property into any > of the options defined in xdisp.c. > > So later on, when looking for a custom-where property in the members of > the display-fill-column-indicator group, we find nothing, resulting in > no custom-loads thingy for display-fill-column-indicator. > > The problem goes away if we require cus-start in cus-dep, or if we > record into the custom-loads the file where to find the custom-group. > That is, add in the first mapatoms call something like this: > (when (get symbol 'custom-where) > (push (get symbol 'custom-where) found)) > > Or if eventually a defface or a defcustom makes its way into > display-fill-column-indicator.el, of course. > > Note that adding the above form will result in adding cus-edit to the > custom-loads property of the groups defined in cus-edit (like editing, > convenience, etc.). I don't know if that is harmless. Stefan, any suggestions regarding which solution route is preferable? Thanks.