From: Eli Zaretskii <eliz@gnu.org>
To: Mauro Aranda <maurooaranda@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 41145@debbugs.gnu.org, p.stephani2@gmail.com
Subject: bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group
Date: Sat, 29 Aug 2020 09:54:13 +0300 [thread overview]
Message-ID: <837dtiymay.fsf@gnu.org> (raw)
In-Reply-To: <CABczVwf767U+nR8AzZ85bTC-cNbgKgTyWnxpmwybWq5aCknTRg@mail.gmail.com> (message from Mauro Aranda on Fri, 28 Aug 2020 11:48:57 -0300)
> From: Mauro Aranda <maurooaranda@gmail.com>
> Date: Fri, 28 Aug 2020 11:48:57 -0300
> Cc: Philipp Stephani <p.stephani2@gmail.com>, 41145@debbugs.gnu.org
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Philipp Stephani <p.stephani2@gmail.com>
> >> Date: Sat, 09 May 2020 10:30:13 +0200
> >>
> >> The two issues here are:
> >>
> >> 1. "Group definition missing." It looks like customizing this group
> >> should load `display-fill-column-indicator-mode', which defines this
> >> group, or the group definition should be in cus-start.el.
> > The same seems to work for display-line-numbers, and I don't think I
> > see the crucial difference.
>
> I did some debugging and found that the difference is that there are no
> custom options or faces defined in display-fill-column-indicator.el:
> fill-column-indicator is in faces.el and
> display-fill-column-indicator, display-fill-column-indicator-character
> and display-fill-column-indicator-column are in xdisp.c
>
> custom-make-dependencies doesn't go through faces.el, since it's
> preloaded, so it doesn't record the custom-where property into
> fill-column-indicator.
> And since cus-dep.el doesn't require cus-start, fill-column-indicator is
> the only member of the custom-group property of
> display-fill-column-indicator, so there is no way
> custom-make-dependencies will record the custom-where property into any
> of the options defined in xdisp.c.
>
> So later on, when looking for a custom-where property in the members of
> the display-fill-column-indicator group, we find nothing, resulting in
> no custom-loads thingy for display-fill-column-indicator.
>
> The problem goes away if we require cus-start in cus-dep, or if we
> record into the custom-loads the file where to find the custom-group.
> That is, add in the first mapatoms call something like this:
> (when (get symbol 'custom-where)
> (push (get symbol 'custom-where) found))
>
> Or if eventually a defface or a defcustom makes its way into
> display-fill-column-indicator.el, of course.
>
> Note that adding the above form will result in adding cus-edit to the
> custom-loads property of the groups defined in cus-edit (like editing,
> convenience, etc.). I don't know if that is harmless.
Stefan, any suggestions regarding which solution route is preferable?
Thanks.
next prev parent reply other threads:[~2020-08-29 6:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 8:30 bug#41145: 27.0.91; small issues with `display-fill-column-indicator' Customization group Philipp Stephani
2020-05-09 9:37 ` Eli Zaretskii
2020-05-09 12:31 ` Philipp Stephani
2020-08-28 14:48 ` Mauro Aranda
2020-08-29 6:54 ` Eli Zaretskii [this message]
2020-08-29 15:36 ` Stefan Monnier
2020-08-29 16:23 ` Mauro Aranda
2020-08-30 3:58 ` Stefan Monnier
2020-08-30 11:52 ` Mauro Aranda
2020-08-30 14:51 ` Stefan Monnier
2020-08-30 15:09 ` Eli Zaretskii
2020-08-30 17:03 ` Stefan Monnier
2020-09-04 2:24 ` Stefan Monnier
2020-09-04 7:09 ` Eli Zaretskii
2020-09-04 12:47 ` Stefan Monnier
2020-08-30 15:09 ` Drew Adams
2020-09-11 23:26 ` Michael Heerdegen
2020-09-12 15:43 ` Stefan Monnier
2020-09-12 18:51 ` Michael Heerdegen
2020-08-30 13:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837dtiymay.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=41145@debbugs.gnu.org \
--cc=maurooaranda@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).