From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13521: `sort-lines' on the empty region Date: Sat, 05 Sep 2020 18:37:00 +0300 Message-ID: <837dt8p74z.fsf@gnu.org> References: <<<20130122085354.75ced82538551655e724e0ea@gmail.com>>> <<>> <<>> <<>> <<>> <<<83mu2objro.fsf@gnu.org>>> <<>> <<<83imdcbgc5.fsf@gnu.org>>> <<>> <<<83imcspim8.fsf@gnu.org>>> <<3aad96d8-2503-40e8-b684-8ed18a089083@default>> <<83a6y4p98g.fsf@gnu.org>> <7cfc062e-05b2-43f1-8714-19ebd955b88c@default> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36383"; mail-complaints-to="usenet@ciao.gmane.io" Cc: xfq.free@gmail.com, rgm@gnu.org, stefan@marxist.se, monnier@iro.umontreal.ca, 13521@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 17:38:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEaGX-0009Ld-Rd for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 17:38:09 +0200 Original-Received: from localhost ([::1]:35766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEaGW-0000cM-Si for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 11:38:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEaGQ-0000c9-R2 for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEaGQ-0005Vl-IH for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEaGQ-0004nx-GO for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 15:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13521-submit@debbugs.gnu.org id=B13521.159932023918420 (code B ref 13521); Sat, 05 Sep 2020 15:38:02 +0000 Original-Received: (at 13521) by debbugs.gnu.org; 5 Sep 2020 15:37:19 +0000 Original-Received: from localhost ([127.0.0.1]:43906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEaFi-0004n2-NZ for submit@debbugs.gnu.org; Sat, 05 Sep 2020 11:37:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEaFg-0004mo-76 for 13521@debbugs.gnu.org; Sat, 05 Sep 2020 11:37:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35431) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEaFa-0005PP-DH; Sat, 05 Sep 2020 11:37:10 -0400 Original-Received: from [176.228.60.248] (port=2541 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kEaFY-0008II-TV; Sat, 05 Sep 2020 11:37:09 -0400 In-Reply-To: <7cfc062e-05b2-43f1-8714-19ebd955b88c@default> (message from Drew Adams on Sat, 5 Sep 2020 08:22:58 -0700 (PDT)) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187269 Archived-At: > Date: Sat, 5 Sep 2020 08:22:58 -0700 (PDT) > From: Drew Adams > Cc: stefan@marxist.se, xfq.free@gmail.com, rgm@gnu.org, > monnier@iro.umontreal.ca, 13521@debbugs.gnu.org > > > > I doubt that someone who has `transient-mark-mode' off > > > would ever want commands such as `flush-lines' and > > > `sort-lines' to act on the region. And if they did, I > > > expect they'd just narrow to it. > > > > Please don't doubt, and please don't impose unnecessary commands on > > users who have transient-mark-mode off. > > Please don't claim that I imposed any commands on anyone. You expected them to narrow the buffer. That takes additional commands. > The region is nearly always present and usually nonempty. > A user with `transient-mark-mode' off would typically > (IMHO) be bothered if `flush-lines' started always acting > on the region (it would be almost always: whenever there's > a mark in the buffer and the region is nonempty). So maybe flush-lines needs a separate solution, or none at all. This bug is about sort-lines, so flush-lines is a tangent. > And I think "the important point here" is that a command > that behaves differently when the region is active should > NOT act on the region when `transient-mark-mode' is off. That's not really relevant here. We are talking about commands which by virtue of their 'interactive' spec work on the region. Such commands shouldn't depend on the region being active. > This was not the case for `sort-lines', as you point out. > It did NOT, and does not, behave differently when the > region is active from when it is inactive. The proposed change would have made it behave differently, which is why I've pointed that out.