From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23590: 25.0.94; Errors in default lgrep command Date: Wed, 07 Oct 2020 11:17:37 +0300 Message-ID: <837ds2a1r2.fsf@gnu.org> References: <87futcp8wp.fsf@gmail.com> <83fur0x0ft.fsf@gnu.org> <87fur0clhm.fsf@gmail.com> <83a8h8utdm.fsf@gnu.org> <838twsuskk.fsf@gnu.org> <87twfg0zrs.fsf@gmail.com> <87r1rh8wgf.fsf@gnus.org> <871ria7ldn.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9281"; mail-complaints-to="usenet@ciao.gmane.io" Cc: john.b.mastro@gmail.com, 23590@debbugs.gnu.org, agrambot@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 07 10:18:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQ4eJ-0002K9-D7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 10:18:11 +0200 Original-Received: from localhost ([::1]:34960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ4eI-0001Ek-Fx for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 04:18:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQ4eA-0001E2-II for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 04:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQ4eA-0007xd-8O for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 04:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQ4eA-0005p6-3w for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 04:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Oct 2020 08:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23590 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 23590-submit@debbugs.gnu.org id=B23590.160205866722364 (code B ref 23590); Wed, 07 Oct 2020 08:18:02 +0000 Original-Received: (at 23590) by debbugs.gnu.org; 7 Oct 2020 08:17:47 +0000 Original-Received: from localhost ([127.0.0.1]:55132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ4dv-0005oe-HI for submit@debbugs.gnu.org; Wed, 07 Oct 2020 04:17:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ4dt-0005oQ-RE for 23590@debbugs.gnu.org; Wed, 07 Oct 2020 04:17:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41661) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ4dn-0007uV-Ds; Wed, 07 Oct 2020 04:17:39 -0400 Original-Received: from [176.228.60.248] (port=2810 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kQ4dg-000411-0C; Wed, 07 Oct 2020 04:17:39 -0400 In-Reply-To: <871ria7ldn.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 07 Oct 2020 05:41:56 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189995 Archived-At: > From: Lars Ingebrigtsen > Cc: john.b.mastro@gmail.com, Eli Zaretskii , > 23590@debbugs.gnu.org > Date: Wed, 07 Oct 2020 05:41:56 +0200 > > Lars Ingebrigtsen writes: > > > There was discussion here before the patch was posted, but then no > > follow-up. I've respun the patch for Emacs 28 -- does anybody have any > > comments? > > There were no comments in a month, and the patch makes sense to me, so > I've applied it to Emacs 28. I'm sorry to not have chimed earlier, but I think this change goes too far. Now the default "M-x grep" command includes --directories=skip if the user's Grep program supports that. This is not a good idea for the general-purpose Grep commands. For example, if the user adds to the default command "-R foo" somewhere before the --directories=skip part, the command will say "no matches", which would be a surprise at best, and at worst could mislead the user. The original bug report was about "M-x lgrep". Can we make this change affect only that command? In any case, this is a user-visible change, so it should be called out in NEWS. Thanks.