From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: john.b.mastro@gmail.com, 23590@debbugs.gnu.org, agrambot@gmail.com
Subject: bug#23590: 25.0.94; Errors in default lgrep command
Date: Wed, 07 Oct 2020 11:17:37 +0300 [thread overview]
Message-ID: <837ds2a1r2.fsf@gnu.org> (raw)
In-Reply-To: <871ria7ldn.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 07 Oct 2020 05:41:56 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: john.b.mastro@gmail.com, Eli Zaretskii <eliz@gnu.org>,
> 23590@debbugs.gnu.org
> Date: Wed, 07 Oct 2020 05:41:56 +0200
>
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> > There was discussion here before the patch was posted, but then no
> > follow-up. I've respun the patch for Emacs 28 -- does anybody have any
> > comments?
>
> There were no comments in a month, and the patch makes sense to me, so
> I've applied it to Emacs 28.
I'm sorry to not have chimed earlier, but I think this change goes too
far. Now the default "M-x grep" command includes --directories=skip
if the user's Grep program supports that. This is not a good idea for
the general-purpose Grep commands. For example, if the user adds to
the default command "-R foo" somewhere before the --directories=skip
part, the command will say "no matches", which would be a surprise at
best, and at worst could mislead the user.
The original bug report was about "M-x lgrep". Can we make this
change affect only that command?
In any case, this is a user-visible change, so it should be called out
in NEWS.
Thanks.
next prev parent reply other threads:[~2020-10-07 8:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 0:11 bug#23590: 25.0.94; Errors in default lgrep command Alex
2016-07-23 2:16 ` John Mastro
2016-07-23 7:45 ` Eli Zaretskii
2016-07-23 16:57 ` John Mastro
2016-07-23 17:15 ` Eli Zaretskii
2016-07-23 17:23 ` John Mastro
2016-07-23 17:58 ` Eli Zaretskii
2016-07-23 19:52 ` Glenn Morris
2016-07-23 17:28 ` Alex
2016-07-23 18:00 ` Eli Zaretskii
2016-07-23 18:18 ` Eli Zaretskii
2016-07-23 22:12 ` Alex
2020-09-04 14:09 ` Lars Ingebrigtsen
2020-10-07 3:41 ` Lars Ingebrigtsen
2020-10-07 8:17 ` Eli Zaretskii [this message]
2020-10-09 4:15 ` Lars Ingebrigtsen
2020-10-13 20:09 ` Juri Linkov
2020-10-14 4:10 ` Lars Ingebrigtsen
2016-07-23 17:11 ` Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837ds2a1r2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23590@debbugs.gnu.org \
--cc=agrambot@gmail.com \
--cc=john.b.mastro@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).