From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: stephen.berman@gmx.net, stefan@marxist.se, 24774@debbugs.gnu.org
Subject: bug#24774: 26.0.50; Menu display navigation commands
Date: Sat, 27 Feb 2021 09:43:55 +0200 [thread overview]
Message-ID: <837dmuoszo.fsf@gnu.org> (raw)
In-Reply-To: <8735xiku8g.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 27 Feb 2021 05:30:39 +0100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: stephen.berman@gmx.net, stefan@marxist.se, 24774@debbugs.gnu.org
> Date: Sat, 27 Feb 2021 05:30:39 +0100
>
> > But the same argument can be brought up for cl-macs.el and cl-lib.el
> > and seq.el and map.el and pcase.el and probably several others.
>
> Yes, of course.
>
> > Where do we stop, if the criterion is "better and more sensible"
> > (which are highly subjective judgments)?
>
> I don't think anybody claims that the non-easymenu way of defining menus
> is superior?
It isn't a catastrophe, IMO, not even close. Non-easymenu:
(bindings--define-key prof-map [prof-natprof-stop]
'(menu-item "Stop Native Profiler" profiler-stop
:help "Stop recording profiling information"
:enable (and (featurep 'profiler)
(profiler-running-p))))
With easymenu:
["Show trailing whitespace" whitespace-mode
:style toggle :selected (bound-and-true-p whitespace-mode)
:help "Show trailing whitespace in modified lines"]
There's some boilerplate in the former, but it isn't unreadable, and
writing it is just a bunch of C-y's in addition to the actual content,
which must be typed in both cases. It isn't superior, but is it so
awfully inferior? I don't think so.
> Our most important code is the one that is in the very core of Emacs,
> and it's a shame we don't use more of these libraries there, and instead
> open-code stuff badly.
I disagree with "shame" and "badly". Next we will see similar
arguments about all the other packages mentioned above.
Again, I think we should agree on some criteria, because otherwise we
will not be able to reconcile subjective opinions about stylistic
issues.
> > I'd like to see the actual numbers, please. And also the memory
> > footprint before and after loading easymenu. With the current code, I
> > see a 0.25MB increase in the VM size after I load easymenu.elc.
>
> Pre patch:
>
> larsi@xo:~/src/emacs/trunk$ ls -l src/emacs src/emacs.pdmp lisp/progmodes/elisp-mode.elc
> -rw-r--r-- 1 larsi larsi 60375 Feb 27 05:09 lisp/progmodes/elisp-mode.elc
> -rwxr-xr-x 2 larsi larsi 32583784 Feb 27 05:10 src/emacs
> -rw-r--r-- 2 larsi larsi 10630544 Feb 27 05:10 src/emacs.pdmp
>
> Post patch:
>
> larsi@xo:~/src/emacs/trunk$ ls -l src/emacs src/emacs.pdmp lisp/progmodes/elisp-mode.elc
> -rw-r--r-- 1 larsi larsi 58798 Feb 27 05:21 lisp/progmodes/elisp-mode.elc
> -rwxr-xr-x 2 larsi larsi 32583784 Feb 27 05:21 src/emacs
> -rw-r--r-- 2 larsi larsi 10632360 Feb 27 05:21 src/emacs.pdmp
>
> (- (+ 10632360 58798) (+ 10630544 60375)) => 239 bytes.
Thanks, but I meant the runtime memory footprint, not the size on disk
(which IMO is of no importance, as long as small savings are being
discussed).
next prev parent reply other threads:[~2021-02-27 7:43 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 16:28 bug#24774: 26.0.50; Menu display navigation commands Andreas Röhler
2019-07-27 13:18 ` Lars Ingebrigtsen
2019-07-30 7:54 ` Andreas Röhler
2019-07-30 10:25 ` Lars Ingebrigtsen
2020-11-18 15:34 ` Stefan Kangas
2020-11-18 21:09 ` Lars Ingebrigtsen
2020-11-18 22:01 ` Drew Adams
2020-11-18 22:16 ` Stefan Kangas
2020-11-18 23:16 ` Drew Adams
2020-11-19 1:10 ` Stefan Kangas
2021-02-23 15:19 ` Stefan Kangas
2021-02-23 15:29 ` Lars Ingebrigtsen
2021-02-23 15:57 ` Eli Zaretskii
2021-02-23 16:02 ` Lars Ingebrigtsen
2021-02-23 16:14 ` Lars Ingebrigtsen
2021-02-23 16:16 ` Eli Zaretskii
2021-02-23 16:37 ` Stefan Kangas
2021-02-23 16:44 ` Eli Zaretskii
2021-02-25 1:25 ` Stefan Kangas
2021-02-25 9:04 ` Stephen Berman
2021-02-25 9:24 ` Eli Zaretskii
2021-02-25 15:09 ` Lars Ingebrigtsen
2021-02-25 15:27 ` Eli Zaretskii
2021-02-25 15:52 ` Lars Ingebrigtsen
2021-02-25 18:18 ` Eli Zaretskii
2021-02-25 19:20 ` Eli Zaretskii
2021-02-26 8:48 ` Lars Ingebrigtsen
2021-02-26 12:04 ` Eli Zaretskii
2021-02-26 12:07 ` Lars Ingebrigtsen
2021-02-26 12:27 ` Eli Zaretskii
2021-02-27 4:30 ` Lars Ingebrigtsen
2021-02-27 5:27 ` Lars Ingebrigtsen
2021-02-27 6:14 ` bug#24774: [External] : " Drew Adams
2021-02-27 7:43 ` Eli Zaretskii [this message]
2021-02-27 11:50 ` Lars Ingebrigtsen
2021-02-27 12:56 ` Eli Zaretskii
2021-02-27 13:25 ` Lars Ingebrigtsen
2021-02-27 13:32 ` Eli Zaretskii
2021-02-27 13:49 ` Lars Ingebrigtsen
2021-02-27 13:58 ` Eli Zaretskii
2021-02-27 14:24 ` Lars Ingebrigtsen
2021-02-26 16:04 ` bug#24774: [External] : " Drew Adams
2021-02-23 16:50 ` Basil L. Contovounesios
2021-02-23 17:10 ` Eli Zaretskii
2021-02-23 17:24 ` Gregory Heytings
2021-02-23 17:37 ` Eli Zaretskii
2021-02-24 15:12 ` Lars Ingebrigtsen
2021-02-24 16:01 ` Stephen Berman
2021-02-24 16:06 ` Lars Ingebrigtsen
2021-02-27 14:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837dmuoszo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24774@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=stefan@marxist.se \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).