From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46824: 28.0.50; nativecomp crash with cl-block/cl-defun Date: Tue, 02 Mar 2021 15:27:54 +0200 Message-ID: <837dmp7kit.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32855"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46824@debbugs.gnu.org, aaronjensen@gmail.com, akrl@sdf.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 02 14:33:48 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lH59n-0008T7-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 14:33:47 +0100 Original-Received: from localhost ([::1]:46540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH59m-0000Yr-Uh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 08:33:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH55C-0003wj-CC for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 08:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lH55C-0001q0-4B for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 08:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lH55C-0000Iy-0D for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 08:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Mar 2021 13:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46824 X-GNU-PR-Package: emacs Original-Received: via spool by 46824-submit@debbugs.gnu.org id=B46824.16146917001118 (code B ref 46824); Tue, 02 Mar 2021 13:29:01 +0000 Original-Received: (at 46824) by debbugs.gnu.org; 2 Mar 2021 13:28:20 +0000 Original-Received: from localhost ([127.0.0.1]:52077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH54W-0000Hy-BJ for submit@debbugs.gnu.org; Tue, 02 Mar 2021 08:28:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lH54V-0000Hl-1i for 46824@debbugs.gnu.org; Tue, 02 Mar 2021 08:28:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40203) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH54P-0001mA-02; Tue, 02 Mar 2021 08:28:13 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1932 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lH547-0004qk-VL; Tue, 02 Mar 2021 08:28:09 -0500 In-Reply-To: (message from Pip Cet on Tue, 2 Mar 2021 09:16:12 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201213 Archived-At: > From: Pip Cet > Date: Tue, 2 Mar 2021 09:16:12 +0000 > Cc: 46824@debbugs.gnu.org, Aaron Jensen > > + gcc_jit_param *params[] = > + { > + gcc_jit_context_new_param (comp.ctxt, NULL, comp.void_ptr_type, "buf"), > + }; Nitpicking: the braces here should be in column zero. > + /* Don't call setjmp through a function pointer (Bug#46824) */ > + return gcc_jit_context_new_call (comp.ctxt, > + NULL, > + gcc_jit_context_new_function > + (comp.ctxt, NULL, GCC_JIT_FUNCTION_IMPORTED, > + comp.int_type, STR (SETJMP_NAME), > + ARRAYELTS (params), params, > + false), > + 1, > + args); Another nit: in cases like this one I find this style more readable: return gcc_jit_context_new_call (comp.ctxt, NULL, gcc_jit_context_new_function (comp.ctxt, NULL, GCC_JIT_FUNCTION_IMPORTED, ... IOW, avoid having the function's name and its arguments on separate lines, as I find that harder to read. Or maybe even this: gcc_jit_rvalue *val = gcc_jit_context_new_call (comp.ctxt, NULL, gcc_jit_context_new_function (comp.ctxt, NULL, GCC_JIT_FUNCTION_IMPORTED, ...), 1, args); return val; However, since this is my personal preference, I won't insist if you find your style preferable. Thanks.