From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Date: Mon, 08 Mar 2021 17:07:30 +0200 Message-ID: <837dmhsmz1.fsf@gnu.org> References: <865z3866my.fsf@gmail.com> <865z38a9vo.fsf@gmail.com> <86eehujcip.fsf@gmail.com> <86blch14qt.fsf@gmail.com> <83h7m84h9g.fsf@gnu.org> <86v9ao5czu.fsf@gmail.com> <86wnutogrh.fsf@gmail.com> <86wnut8fb9.fsf@gmail.com> <861rd1tbpa.fsf@gmail.com> <83pn0km6y3.fsf@gnu.org> <86ft1f8ara.fsf@gmail.com> <83sg5cjdn8.fsf@gnu.org> <83r1kwjcy2.fsf@gnu.org> <8335x6u9o4.fsf@gnu.org> <83zgzesrku.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8370"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46256@debbugs.gnu.org, andrewjmoreton@gmail.com To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 08 16:11:07 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJHXF-0001zn-Q1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Mar 2021 16:11:05 +0100 Original-Received: from localhost ([::1]:58040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJHXE-00041x-R9 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Mar 2021 10:11:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJHUI-0006zn-Am for bug-gnu-emacs@gnu.org; Mon, 08 Mar 2021 10:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32974) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJHUI-0001iE-21 for bug-gnu-emacs@gnu.org; Mon, 08 Mar 2021 10:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJHUH-0004c9-Sj for bug-gnu-emacs@gnu.org; Mon, 08 Mar 2021 10:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Mar 2021 15:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46256 X-GNU-PR-Package: emacs Original-Received: via spool by 46256-submit@debbugs.gnu.org id=B46256.161521606817714 (code B ref 46256); Mon, 08 Mar 2021 15:08:01 +0000 Original-Received: (at 46256) by debbugs.gnu.org; 8 Mar 2021 15:07:48 +0000 Original-Received: from localhost ([127.0.0.1]:44520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJHU4-0004bd-7g for submit@debbugs.gnu.org; Mon, 08 Mar 2021 10:07:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJHU2-0004bO-KF for 46256@debbugs.gnu.org; Mon, 08 Mar 2021 10:07:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49363) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJHTx-0001ZW-Fx; Mon, 08 Mar 2021 10:07:41 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2027 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lJHTu-0007GY-L3; Mon, 08 Mar 2021 10:07:41 -0500 In-Reply-To: (message from Andrea Corallo on Sun, 07 Mar 2021 20:16:40 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201840 Archived-At: > From: Andrea Corallo > Cc: 46256@debbugs.gnu.org, andrewjmoreton@gmail.com > Date: Sun, 07 Mar 2021 20:16:40 +0000 > > > #1 0x0135a63b in emacs_abort () at w32fns.c:10914 > > #2 0x0115c637 in terminate_due_to_signal (sig=22, backtrace_limit=2147483647) > > at emacs.c:417 > > #3 0x0121c026 in die (msg=0x1782af2 "NATIVE_COMP_UNITP (a)", > > file=0x1782aeb "comp.h", line=70) at alloc.c:7452 > > #4 0x012cf582 in XNATIVE_COMP_UNIT (a=XIL(0x6f04860091b9000)) at comp.h:70 > > #5 0x012df324 in load_comp_unit (comp_u=0x6f33918, loading_dump=false, > > late_load=false) at comp.c:4821 > > #6 0x012e0c55 in Fnative_elisp_load (filename=XIL(0x80000000092db190), > > late_load=XIL(0)) at comp.c:5122 > > What I think is going on here: > > The same .eln file is loaded two times, we detect that and try to reuse > the same compilation unit (the Lisp object) instead of a new one. > > We keep a pointer to the compilation unit representing the .eln file in > each .eln. Here we read it and we have it into 'saved_cu', we try to > dereference it and extract the CU with XNATIVE_COMP_UNIT but something > goes wrong. > > This object might have been GC'ed for some reason and we might be > looking at the same GC issue I've seen on 32bit wide-int (my guess). > *If* this is the case the question is: why is the CU GC'ed? Can you please step back a notch for a moment and help me understand how this machinery works? Because I'm looking at the code, and I'm confused. For example, I see this: Lisp_Object *saved_cu = dynlib_sym (handle, COMP_UNIT_SYM); comp_u->loaded_once = !NILP (*saved_cu); But dynlib_sym doesn't return a pointer to a Lisp_Object, it returns a pointer to a function or a variable inside the .eln shared library. So how is this TRT? A few lines later we do this: comp_u_lisp_obj = *saved_cu; comp_u = XNATIVE_COMP_UNIT (comp_u_lisp_obj); But if saved_cu is NOT a pointer to a Lisp_Object, then how do we expect XNATIVE_COMP_UNIT not to crash? What am I missing?