From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48149: 27.2; Wrong underline width when the line char has a width of 2 Date: Sun, 02 May 2021 10:17:53 +0300 Message-ID: <837dkh8uzi.fsf__22492.4155323365$1619940077$gmane$org@gnu.org> References: <87fsz62b1w.wl-shingo.fg8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24763"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48149@debbugs.gnu.org To: Shingo Tanaka Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 02 09:21:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ld6Ph-0006N1-E4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 May 2021 09:21:13 +0200 Original-Received: from localhost ([::1]:46650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ld6Pg-0006gQ-HN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 May 2021 03:21:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ld6Nc-0005No-1I; Sun, 02 May 2021 03:19:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57763) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ld6Na-0001au-TX; Sun, 02 May 2021 03:19:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ld6Na-0007Jy-QD; Sun, 02 May 2021 03:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: emacs-orgmode@gnu.org, bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 May 2021 07:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48149 X-GNU-PR-Package: org-mode,emacs Original-Received: via spool by 48149-submit@debbugs.gnu.org id=B48149.161993990128107 (code B ref 48149); Sun, 02 May 2021 07:19:02 +0000 Original-Received: (at 48149) by debbugs.gnu.org; 2 May 2021 07:18:21 +0000 Original-Received: from localhost ([127.0.0.1]:41069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld6Mv-0007JH-Ko for submit@debbugs.gnu.org; Sun, 02 May 2021 03:18:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld6Mt-0007J9-Tz for 48149@debbugs.gnu.org; Sun, 02 May 2021 03:18:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57273) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ld6Mo-00010C-OB; Sun, 02 May 2021 03:18:14 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2429 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ld6Mn-0001zH-4S; Sun, 02 May 2021 03:18:14 -0400 In-Reply-To: <87fsz62b1w.wl-shingo.fg8@gmail.com> (message from Shingo Tanaka on Sun, 02 May 2021 10:12:43 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205383 Archived-At: > Date: Sun, 02 May 2021 10:12:43 +0900 > From: Shingo Tanaka > > When exporting org-mode document to plain text (either ascii/unicode/utf-8) > with `org-export-dispatch', Emacs inserts lines under headlines, inline > tasks, table rows and titles of the document, TOC, list of listings, list of > tables and footnotes. The problem is it inserts too long (double width) line > when the line character has a width of 2. > > Those lines are made of 3 types of characters below (in ox-ascii.el): > 1) org-ascii-underline > 2) (if (eq (plist-get info :ascii-charset) 'utf-8) ?─ ?_) > 3) (if utf8p ?━ ?_) > > In case of 1), it correctly takes account of the case in which the character > has a width of 2 in `org-ascii--build-title', by dividing the line width by > `(char-width under-char)' (line 700-701), maybe because the character is user > configurable and its width in unknown. However, in case of 2) and > 3), maybe because the characters is embedded in the code, it looks like only > considering the character always has a width of 1. But the reality is > character ?─ or ?━ can have a width of 2 in the screen displayed with some > fonts (ex. "Noto Sans Mono CJK JP"), and in that case the line width gets > doubled of the expected width. > > Attached one is a potential patch. The basic concepts are: > > a) Do the same in case of 2) and 3) as in case of 1) > (dividing the line width by `(char-width under-char)', > assuming `char-width-table' is correctly set) > > b) Prefer the longer line width if the width is odd, even in case of 1) > (adding `(1- (char-width under-char))' to dividend, > just because it should be more beautiful ;-) ) You reported a similar bug already, and I replied there that TRT in these cases is to use window-text-pixel-size, which will automatically account for the actual width on display of any characters and any fonts specified for displaying them. char-width is an approximation, and is accurate only on TTY frames.