From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48493: 28.0.50; quit-window doesn't work Date: Tue, 08 Jun 2021 15:09:49 +0300 Message-ID: <837dj4ftgy.fsf@gnu.org> References: <87h7j0wwkf.fsf@gmail.com> <87cztg41zy.fsf@host.localdomain> <878s434ls1.fsf@host.localdomain> <877djn3r3i.fsf@host.localdomain> <8735u94gt4.fsf@host.localdomain> <87r1hd8bsd.fsf@riseup.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7451"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pillule@riseup.net, sujith.wall@gmail.com, 48493@debbugs.gnu.org To: pillule Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 08 14:16:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqaea-0001l4-IC for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Jun 2021 14:16:20 +0200 Original-Received: from localhost ([::1]:51832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqaeZ-00046A-Dl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Jun 2021 08:16:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqaZS-0006CN-GV for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 08:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46059) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqaZS-0003Bz-7Q for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 08:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqaZS-00054J-38 for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 08:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Jun 2021 12:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 48493-submit@debbugs.gnu.org id=B48493.162315422419431 (code B ref 48493); Tue, 08 Jun 2021 12:11:02 +0000 Original-Received: (at 48493) by debbugs.gnu.org; 8 Jun 2021 12:10:24 +0000 Original-Received: from localhost ([127.0.0.1]:57605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqaYp-00053L-NB for submit@debbugs.gnu.org; Tue, 08 Jun 2021 08:10:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqaYo-000539-KI for 48493@debbugs.gnu.org; Tue, 08 Jun 2021 08:10:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59468) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqaYj-0002i2-8G; Tue, 08 Jun 2021 08:10:17 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1700 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqaYa-0001ud-Tk; Tue, 08 Jun 2021 08:10:16 -0400 In-Reply-To: <87r1hd8bsd.fsf@riseup.net> (message from pillule on Tue, 08 Jun 2021 01:23:11 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208228 Archived-At: > From: pillule > Date: Tue, 08 Jun 2021 01:23:11 +0200 > Cc: pillule , Sujith Manoharan , > 48493@debbugs.gnu.org > > > We have to document it in the Elisp manual. > > Here another draft with the info manual changes: Thanks. Once again, I leave it to Martin and others to comment on most of the essence of the patch, and provide here only few minor nits: > * doc/lispref/windows.texi > (Buffers and Windows): mention the exception of side windows and > add a reference. > (Buffer Display Action Alists): explicit that > `display-buffer-in-side-window' is dedicating to side by default. > (Dedicated Windows): add the case (4) and explicit its meaning, > add a reference. > (Displaying Buffers in Side Windows): move the > switch-to-(prev|next)-buffer paragraph into a new item to emphasize > the special meaning of dedication for side windows. Again, this log message is not formatted according to our rules. It should look like this: * doc/lispref/windows.texi (Buffers and Windows): Mention the exception of side windows and add a reference. (Buffer Display Action Alists): Say explicitly that 'display-buffer-in-side-window' is dedicating to side by default. (Dedicated Windows): Add case (4) and explain its meaning, add a reference. (Displaying Buffers in Side Windows): Move the paragraph about 'switch-to-(prev|next)-buffer' into a new item to emphasize the special meaning of dedication for side windows. Note that I also fixed the wording a bit, and that our conventions for quoting in log entries is 'like this'. > The replacement buffer in each window is chosen via > -@code{switch-to-prev-buffer} (@pxref{Window History}). Any dedicated > -window displaying @var{buffer-or-name} is deleted if possible > -(@pxref{Dedicated Windows}). If such a window is the only window on its > -frame and there are other frames on the same terminal, the frame is > -deleted as well. If the dedicated window is the only window on the only > -frame on its terminal, the buffer is replaced anyway. > +@code{switch-to-prev-buffer} (@pxref{Window History}). With the > +exception of side windows, any dedicated window displaying ^^^^^^^^^^^^^^^^^^^^^^^^^ Here' it is quite important that the reader understands what are "side windows", otherwise he/she will not understand the exception. However, "side window" was not yet described in the manual by this point, and its description is not in this section. In these cases, always include a cross-reference to where the term is described, like this: With the exception of side windows (@pxref{Side Windows}), any ... > In particular, @code{delete-windows-on} (@pxref{Deleting Windows}) > -handles case (2) by deleting the associated frame and case (3) by > -showing another buffer in that frame's only window. The function > +handles case (2) by deleting the associated frame and case (3) and (4) ^^^^ "cases", plural. > +@item dedicated > +The dedicated flag is not reserved to this function but have a ^ ^^^^ A comma is missing before "but". Also, please use "has" instead of "have". > +slightly different meaning for side windows. They receive it upon > +creation with the value @code{side}; it serves to prevent > +@code{display-buffer} to uses these windows with others action ^^^^^^^ "to use" > +functions, and it persists across invocations of @code{quit-window}, > +@code{kill-buffer}, @code{previous-buffer} and @code{next-buffer} > +(@pxref{note Window History}). In particular, these commands will ^^^^^^^^^^^^^^^^^^^ No need for "note" here.