From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable Date: Thu, 16 Sep 2021 15:25:24 +0300 Message-ID: <837dfgaerv.fsf@gnu.org> References: <83o8ary5kl.fsf@gnu.org> <87pmtbj81v.fsf@gmail.com> <8335q7c655.fsf@gnu.org> <87pmta6buq.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11583"; mail-complaints-to="usenet@ciao.gmane.io" Cc: phst@google.com, 49723@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 16 14:26:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQqSw-0002qE-T8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 14:26:10 +0200 Original-Received: from localhost ([::1]:50588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQqSv-00074L-NO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Sep 2021 08:26:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQqSo-00071n-Do for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 08:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQqSo-0005RK-58 for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 08:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQqSn-0002JZ-VC for bug-gnu-emacs@gnu.org; Thu, 16 Sep 2021 08:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Sep 2021 12:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49723 X-GNU-PR-Package: emacs Original-Received: via spool by 49723-submit@debbugs.gnu.org id=B49723.16317951488874 (code B ref 49723); Thu, 16 Sep 2021 12:26:01 +0000 Original-Received: (at 49723) by debbugs.gnu.org; 16 Sep 2021 12:25:48 +0000 Original-Received: from localhost ([127.0.0.1]:54053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQqSZ-0002J4-Iv for submit@debbugs.gnu.org; Thu, 16 Sep 2021 08:25:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQqSX-0002Iq-8U for 49723@debbugs.gnu.org; Thu, 16 Sep 2021 08:25:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49338) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQqSR-0005AO-Vo; Thu, 16 Sep 2021 08:25:39 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2055 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQqSD-0008Vj-TN; Thu, 16 Sep 2021 08:25:38 -0400 In-Reply-To: <87pmta6buq.fsf@gmail.com> (message from Federico Tedin on Wed, 15 Sep 2021 00:17:33 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214454 Archived-At: > From: Federico Tedin > Cc: phst@google.com, 49723@debbugs.gnu.org > Date: Wed, 15 Sep 2021 00:17:33 +0200 > > Ok! Here's my first try at this. I ended up skipping the check on > DEFAULT-DIRECTORY since as you mentioned, its value is used with > expand-file-name itself. In the other case, if default-directory is > picked up, then I checked the value of that variable. Thanks, this LGTM. > +** 'expand-file-name' now checks for null bytes in filenames. > +The function will now check for null bytes in both NAME and > +DEFAULT-DIRECTORY arguments, as well as in the 'default-directory' > +buffer-local variable, assuming its value is used. This should say that if null bytes are found, expand-file-name will signal an error.