unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: rgm@gnu.org, monnier@iro.umontreal.ca, 46472@debbugs.gnu.org
Subject: bug#46472: Make lisp/mail/uce.el obsolete
Date: Fri, 15 Oct 2021 13:46:59 +0300	[thread overview]
Message-ID: <837deek1jw.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkm=kNYXHNZwah7_BC7=nMiJmWdDTCVmq-2TQ7U+vD5QnHg@mail.gmail.com> (message from Stefan Kangas on Fri, 15 Oct 2021 03:50:17 -0500)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 15 Oct 2021 03:50:17 -0500
> Cc: 46472@debbugs.gnu.org, rgm@gnu.org, monnier@iro.umontreal.ca
> 
> > I'd like to see the patch for master, please.
> 
> Please see the attached.
> 
> * lisp/mail/uce.el: Recommend against its use.  (Bug#46472)

This should mention the function in which you make the change.

> Do not merge to master.

???

> --- a/lisp/mail/uce.el
> +++ b/lisp/mail/uce.el
> @@ -358,7 +358,30 @@ uce-reply-to-uce
>        ;; Run hooks before we leave buffer for editing.  Reasonable usage
>        ;; might be to set up special key bindings, replace standard
>        ;; functions in mail-mode, etc.
> -      (run-hooks 'mail-setup-hook 'uce-setup-hook))))
> +      (run-hooks 'mail-setup-hook 'uce-setup-hook)))
> +  (pop-to-buffer (get-buffer-create "uce-reply-to-uce warning"))
> +  (insert "\
> +-- !!! NOTE !!! ---------------------------------------------

This should pop only once per Emacs session, not each time the command
is invoked.

I also think we should have in the Commentary section something like
this:

  ;; We don't recommend using this feature; see the message in
  ;; 'uce-reply-to-uce' for the reasons.

Thanks.





  reply	other threads:[~2021-10-15 10:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 21:58 bug#46472: Make lisp/mail/uce.el obsolete Stefan Kangas
2021-02-13  7:58 ` Eli Zaretskii
2021-02-13 12:25   ` Stefan Kangas
2021-02-13 14:00     ` Eli Zaretskii
2021-03-04 19:27       ` Glenn Morris
2021-03-04 21:12         ` Eli Zaretskii
2021-03-06 17:14           ` Stefan Kangas
2021-03-06 17:25             ` Eli Zaretskii
2022-06-17 13:07         ` Lars Ingebrigtsen
2021-10-12  4:33       ` Stefan Kangas
2021-10-12 13:52         ` Eli Zaretskii
2021-10-12 16:12           ` Stefan Kangas
2021-10-12 16:44             ` Eli Zaretskii
2021-10-12 17:29               ` Stefan Kangas
2021-10-12 18:50                 ` Eli Zaretskii
2021-10-14 20:45                   ` Stefan Kangas
2021-10-15  6:12                     ` Eli Zaretskii
2021-10-15  8:50                       ` Stefan Kangas
2021-10-15 10:46                         ` Eli Zaretskii [this message]
2021-10-16 12:48                           ` Stefan Kangas
2021-10-16 12:50                             ` Eli Zaretskii
2021-10-17 23:56                               ` Stefan Kangas
2021-10-16 12:32                       ` Stefan Kangas
2021-03-03 21:22   ` Stefan Monnier
2021-03-04  3:39     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837deek1jw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=46472@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rgm@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).