From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51296: [PATCH] Add WebP format support Date: Wed, 20 Oct 2021 16:14:47 +0300 Message-ID: <837de7bzy0.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15919"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51296@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 20 15:15:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdBRH-0003wu-GO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 15:15:27 +0200 Original-Received: from localhost ([::1]:36822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdBRG-0000D7-Jh for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Oct 2021 09:15:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdBQs-0000CK-Sk for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 09:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdBQr-0000kd-R8 for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 09:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdBQr-0000QJ-JW for bug-gnu-emacs@gnu.org; Wed, 20 Oct 2021 09:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Oct 2021 13:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51296-submit@debbugs.gnu.org id=B51296.16347356831584 (code B ref 51296); Wed, 20 Oct 2021 13:15:01 +0000 Original-Received: (at 51296) by debbugs.gnu.org; 20 Oct 2021 13:14:43 +0000 Original-Received: from localhost ([127.0.0.1]:53026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdBQZ-0000PU-AF for submit@debbugs.gnu.org; Wed, 20 Oct 2021 09:14:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdBQW-0000PG-T4 for 51296@debbugs.gnu.org; Wed, 20 Oct 2021 09:14:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38904) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdBQR-0000ES-Ms; Wed, 20 Oct 2021 09:14:35 -0400 Original-Received: from [87.69.77.57] (port=1393 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdBQR-00073H-9m; Wed, 20 Oct 2021 09:14:35 -0400 In-Reply-To: (message from Stefan Kangas on Wed, 20 Oct 2021 06:02:09 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217668 Archived-At: > From: Stefan Kangas > Date: Wed, 20 Oct 2021 06:02:09 -0700 > > Stefan Kangas writes: > > > Reviews are welcome, as usual. > > Another thing that I forgot to add is that this is 100 % untested on > MS-Windows. I made an attempt to add in the DLL-stuff based on pattern > recognition and guesswork, but it'd hardly be surprising if I messed up > somewhere. You missed the fact that the MW-Windows build loads image libraries on-demand, when/if the library is first required. That affects the way we support these in configure.ac, and it also needs an addition to dynamic-library-alist in w32-win.el. It should be easy to add those nits (assuming the code works ;-)