From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Date: Mon, 15 Nov 2021 14:38:08 +0200 Message-ID: <837dd9twzz.fsf@gnu.org> References: <87bl2nhbyp.fsf@163.com> <83bl2nugao.fsf@gnu.org> <87r1biqs7w.fsf@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24362"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51821@debbugs.gnu.org To: "Feng Shu" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 15 13:40:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmbHm-00069V-EE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Nov 2021 13:40:34 +0100 Original-Received: from localhost ([::1]:36582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmbHk-0000yW-77 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Nov 2021 07:40:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmbGI-0000xA-7z for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 07:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmbGH-0002gS-Ss for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 07:39:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmbGH-0006bp-Qf for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 07:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Nov 2021 12:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51821 X-GNU-PR-Package: emacs Original-Received: via spool by 51821-submit@debbugs.gnu.org id=B51821.163697991125364 (code B ref 51821); Mon, 15 Nov 2021 12:39:01 +0000 Original-Received: (at 51821) by debbugs.gnu.org; 15 Nov 2021 12:38:31 +0000 Original-Received: from localhost ([127.0.0.1]:52909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmbFm-0006b2-Ng for submit@debbugs.gnu.org; Mon, 15 Nov 2021 07:38:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmbFl-0006ar-K4 for 51821@debbugs.gnu.org; Mon, 15 Nov 2021 07:38:29 -0500 Original-Received: from [2001:470:142:3::e] (port=60232 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmbFg-0002cC-5O; Mon, 15 Nov 2021 07:38:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=LZxNMX4Karb3tMi2zg84vOrBdwKnubV+2eVxyT7TxTw=; b=atqhwJyUnxVJoCi1jBLK fjqfz6xkyhFCcBpkpmq7lCMIkbyG6R13UJub6DqL8nSm3LsZV2YTkUw1spyVEpf/7j6ZV3qEiwUol WqPm19fwSO41ehRavVCdRrmnzQEtbZwiGIOpWhJxu2s7hBzih6Pqc/KRh3ZE722xUPeA403RNw7Zf aWHd3Z4icb0pTtOoHLeB7aarJQxTQRjNBl23bYfntyLMDXH/g2VYGRNeWFZxLNLLW3WU20YByPo4d f8bHuCWuouC0yEujt5ybziEDqdIlbqn1UwUlXCl+9sWY9aoG2jgmPNHBoFlBegPxxsuyZKxi/5e7U qt2yCDRVQ9rNCw==; Original-Received: from [87.69.77.57] (port=1296 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmbFa-00077G-DA; Mon, 15 Nov 2021 07:38:19 -0500 In-Reply-To: <87r1biqs7w.fsf@163.com> (tumashu@163.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220049 Archived-At: > From: "Feng Shu" > Cc: 51821@debbugs.gnu.org > Date: Mon, 15 Nov 2021 06:37:23 +0800 > > I think user should set to (t . RATIO) instead in most case. > > Maybe line-height can be a alist ((face1 . RATIO) (face2 .RATIO)). > > > ‘(FACE . RATIO)’ > If the height spec is a cons of the format shown, the numeric > height is RATIO times the height of face FACE. RATIO can be any > type of number, or ‘nil’ which means a ratio of 1. If FACE is ‘t’, > it refers to the current face. No, I don't think RATIO can solve the problem, because it will cause both the ASCII and the Chinese fonts to be enlarged, and you will again see the same problem. AFAIU, you explicitly want to have _different_ behavior with ASCII and Chinese fonts of the default face, and that cannot be handled on the face level, because on that level we cannot distinguish between the two fonts. > > So if we require all the lines to be at least line-height pixels, > > those smaller lines will also become higher, and that is not what's > > expected, I guess? > > If user set line-height to a INTEGER with a variable, I think it > is user expected. I don't think it's wise to provide features that trip naïve users and then tell them "you asked for it". It won't be appreciated, and we will have bug reports.