From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#4587: bug#4597: Antwort: Re: bug#4587: 23.1; sort-lines and sort-fields always set buffer modified Date: Wed, 04 May 2022 10:21:08 +0300 Message-ID: <837d714vbv.fsf@gnu.org> References: <874k26to6e.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17448"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 4587@debbugs.gnu.org, Roland.Meier@continental-corporation.com, 4597@debbugs.gnu.org, rm369@arcor.de To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 04 09:25:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nm9No-0004Oc-Pz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 May 2022 09:25:12 +0200 Original-Received: from localhost ([::1]:39768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nm9Nm-0007sI-PT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 May 2022 03:25:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nm9Kk-0006By-1j for bug-gnu-emacs@gnu.org; Wed, 04 May 2022 03:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nm9Kj-0003TQ-OF for bug-gnu-emacs@gnu.org; Wed, 04 May 2022 03:22:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nm9Kj-0000BF-KD for bug-gnu-emacs@gnu.org; Wed, 04 May 2022 03:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 May 2022 07:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4587 X-GNU-PR-Package: emacs Original-Received: via spool by 4587-submit@debbugs.gnu.org id=B4587.1651648866603 (code B ref 4587); Wed, 04 May 2022 07:22:01 +0000 Original-Received: (at 4587) by debbugs.gnu.org; 4 May 2022 07:21:06 +0000 Original-Received: from localhost ([127.0.0.1]:41603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nm9Jq-00009Z-AA for submit@debbugs.gnu.org; Wed, 04 May 2022 03:21:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nm9Jo-00008U-1c; Wed, 04 May 2022 03:21:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48094) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nm9Jh-0003JX-IV; Wed, 04 May 2022 03:20:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zgPPfi6VeTk1sqDuS5I3pLHxgMfs3yhYxEpWTuTPJtw=; b=VpsYisoYx5Ig J26UR5LRiJ2N+WBw+C0+8l8ZO+Jzbs6F9e6dFNseVZKTmWxk19WExGGBw1zDaTGtWM6nxZAVPuUbO sjBA8Ll/5Qpz6VDYjI1i5W9QpWr3Sfe53APrSPZzRGfRwfZOrwFF/5yHtM//wF59IrtRGBcXtxSEs rD8eTOgOkfD2KNnkeatFhQNlnkFBTQus4gk9gkxctKSIhEuscXj80fejr4Qao3BSkeDJBkqMOEEP1 FR5c4rHN0kUCoTJPsEmF0bOM+w1If5jPjPo5GeeHWag+nsyTLdcknL0Vd9IAOwphmx0q4e1TGTMi8 3TErhDLQ52PeWC5+s7ajug==; Original-Received: from [87.69.77.57] (port=3994 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nm9Jf-0007Ky-QN; Wed, 04 May 2022 03:20:56 -0400 In-Reply-To: <874k26to6e.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 03 May 2022 21:24:09 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231368 Archived-At: > Resent-From: Lars Ingebrigtsen > Original-Sender: "Debbugs-submit" > Resent-CC: bug-gnu-emacs@gnu.org > Resent-Sender: help-debbugs@gnu.org > Cc: 4587@debbugs.gnu.org, rm369@arcor.de, 4597@debbugs.gnu.org > From: Lars Ingebrigtsen > Date: Tue, 03 May 2022 21:24:09 +0200 > > Roland.Meier@continental-corporation.com writes: > > > M-x sort-lines and M-x sort-fields always set the buffer modified > > status ("-" -> "*" in column 5 of the status line), even if the region > > was sorted and the command did not modify anything. > > An unmodified buffer should stay unmodified if nothing was changed. > > (I'm going through old bug reports that unfortunately weren't resolved > at the time.) > > I've now fixed this in Emacs 29. This uses buffer-hash, which is only sensitive to changes in the byte sequences of the buffer text. AFAIU, it doesn't know about other possible changes we perceive as "buffer changes", like changes in faces, overlays, buffer-file-coding-system, etc. Shouldn't this be prominently documented in the macro's doc string?