unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 4587@debbugs.gnu.org, Roland.Meier@continental-corporation.com,
	4597@debbugs.gnu.org, rm369@arcor.de
Subject: bug#4587: bug#4597: Antwort: Re: bug#4587: 23.1; sort-lines and sort-fields always set buffer modified
Date: Wed, 04 May 2022 10:21:08 +0300	[thread overview]
Message-ID: <837d714vbv.fsf@gnu.org> (raw)
In-Reply-To: <874k26to6e.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue,  03 May 2022 21:24:09 +0200)

> Resent-From: Lars Ingebrigtsen <larsi@gnus.org>
> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
> Resent-CC: bug-gnu-emacs@gnu.org
> Resent-Sender: help-debbugs@gnu.org
> Cc: 4587@debbugs.gnu.org, rm369@arcor.de, 4597@debbugs.gnu.org
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 03 May 2022 21:24:09 +0200
> 
> Roland.Meier@continental-corporation.com writes:
> 
> > M-x sort-lines and M-x sort-fields always set the buffer modified 
> > status ("-" -> "*" in column 5 of the status line), even if the region 
> > was sorted and the command did not modify anything. 
> > An unmodified buffer should stay unmodified if nothing was changed. 
> 
> (I'm going through old bug reports that unfortunately weren't resolved
> at the time.)
> 
> I've now fixed this in Emacs 29.

This uses buffer-hash, which is only sensitive to changes in the byte
sequences of the buffer text.  AFAIU, it doesn't know about other
possible changes we perceive as "buffer changes", like changes in
faces, overlays, buffer-file-coding-system, etc.  Shouldn't this be
prominently documented in the macro's doc string?





  reply	other threads:[~2022-05-04  7:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-29 16:38 bug#4587: 23.1; sort-lines and sort-fields always set buffer modified Roland.Meier
2009-09-30  4:44 ` Stefan Monnier
2009-09-30 10:00   ` bug#4597: Antwort: " Roland.Meier
2009-09-30 13:51     ` bug#4587: " Stefan Monnier
2009-10-01 12:25       ` Kevin Rodgers
2009-10-01 14:19         ` Stefan Monnier
2009-10-25 13:41           ` Kevin Rodgers
2009-10-25 15:27             ` Stefan Monnier
2009-09-30 16:56     ` bug#4597: " Magnus Henoch
2022-05-03 19:24 ` bug#4587: " Lars Ingebrigtsen
2022-05-04  7:21   ` Eli Zaretskii [this message]
2022-05-04  7:53     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837d714vbv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=4587@debbugs.gnu.org \
    --cc=4597@debbugs.gnu.org \
    --cc=Roland.Meier@continental-corporation.com \
    --cc=larsi@gnus.org \
    --cc=rm369@arcor.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).