From: Eli Zaretskii <eliz@gnu.org>
To: Duncan Findlay <duncf@google.com>
Cc: 55883@debbugs.gnu.org
Subject: bug#55883: [PATCH] Update X Primary Selection with active regions
Date: Tue, 14 Jun 2022 15:15:06 +0300 [thread overview]
Message-ID: <837d5jtp9x.fsf@gnu.org> (raw)
In-Reply-To: <CAPANw+Mrgkz_yxcYy2ZwxtSoasia-z7xpRdmeCC6aApRNwdGFg@mail.gmail.com> (message from Duncan Findlay on Mon, 13 Jun 2022 23:36:13 -0700)
> From: Duncan Findlay <duncf@google.com>
> Date: Mon, 13 Jun 2022 23:36:13 -0700
> Cc: 55883@debbugs.gnu.org
>
> > > --- a/lisp/frame.el
> > > +++ b/lisp/frame.el
> > > @@ -2164,6 +2164,8 @@ display-selections-p
> > > (not (null dos-windows-version))))
> > > ((memq frame-type '(x w32 ns pgtk))
> > > t)
> > > + ((terminal-parameter display 'display-selections-p)
> > > + t)
> >
> > This should test xterm--set-selection parameter.
>
> OK, so the goal is to check the xterm--set-selection terminal
> parameter and variable xterm-select-active-regions before selecting
> the active region in deactivate-mark in simple.el.
>
> We could do this in display-selections-p, but given that these
> variables are not obviously related to display-selections-p, it seems
> to me we probably want to do this check in deactivate-mark instead.
> Does that seem reasonable to you?
I think I'd prefer to have it in display-selections-p, like your last
version did, just using xterm--set-selection terminal parameter, not
the new one you invented.
> > I think the code should instead check the value of
> > xterm-select-active-regions in keyboard.c, where it decides whether to
> > set PRIMARY. (Let me know if you need guidance for how to reference a
> > Lisp variable from C.)
>
> This seems to work -- is there a better way?
>
> !NILP (SYMBOL_VAL (XSYMBOL (Qxterm_select_active_regions)))
This is not safe, IMO. I think this is better:
if ((!NILP (Fwindow_system (Qnil))
|| ((symval = find_symbol_value (Qxterm_select_active_regions),
(!EQ (symval, Qunbound) && !NILP (symval)))
&& !NILP (Fterminal_parameter (Qnil, Qxterm__set_selection))))
> I've also addressed Po's comments about long conditionals.
Thanks, the patch LGTM, modulo the above 2 minor nits.
next prev parent reply other threads:[~2022-06-14 12:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 6:18 bug#55883: [PATCH] Update X Primary Selection with active regions Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-10 6:52 ` Eli Zaretskii
2022-06-11 1:59 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-11 7:53 ` Eli Zaretskii
2022-06-14 5:57 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-14 6:36 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-14 12:15 ` Eli Zaretskii [this message]
2022-06-15 2:01 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-15 16:51 ` Eli Zaretskii
2022-06-18 11:13 ` Eli Zaretskii
2022-06-18 15:15 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-18 16:09 ` Eli Zaretskii
2022-06-22 1:58 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-22 13:02 ` Eli Zaretskii
2022-06-22 15:37 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837d5jtp9x.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55883@debbugs.gnu.org \
--cc=duncf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).