From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56809: file-name-with-extension: Improve docstring. Date: Thu, 28 Jul 2022 11:57:25 +0300 Message-ID: <837d3xaa2y.fsf@gnu.org> References: <87edy5929v.fsf@cassou.me> <83ilnhad8j.fsf@gnu.org> <87bkt98wju.fsf@cassou.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11813"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56809@debbugs.gnu.org To: Damien Cassou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 28 11:25:03 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGzlP-0002wI-MF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Jul 2022 11:25:03 +0200 Original-Received: from localhost ([::1]:56238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGzlO-00060f-M1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Jul 2022 05:25:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGzLH-0005vD-5K for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2022 04:58:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGzLF-0002Vo-Ue for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2022 04:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oGzLF-0005rw-Nz for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2022 04:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Jul 2022 08:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56809-submit@debbugs.gnu.org id=B56809.165899866322527 (code B ref 56809); Thu, 28 Jul 2022 08:58:01 +0000 Original-Received: (at 56809) by debbugs.gnu.org; 28 Jul 2022 08:57:43 +0000 Original-Received: from localhost ([127.0.0.1]:57565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGzKx-0005rH-5n for submit@debbugs.gnu.org; Thu, 28 Jul 2022 04:57:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGzKv-0005r0-NY for 56809@debbugs.gnu.org; Thu, 28 Jul 2022 04:57:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46670) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGzKo-0002TW-Kd; Thu, 28 Jul 2022 04:57:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ay6EaM6D2GPUojmRdsR4LyhwR3ZCXdH3yDWuP2fLHTE=; b=m7XB4AsAo9LSu/JP4hFQ UUCTMWxtbdldYD0QQg+ImWm51CK3QP3Q1aWx/svEBE22NQLYqyLY4MvHvb4Mx45IsPPQbVYYk2JB1 jUuwZAZBYabKoPlFG5JrKL7QB2M1xrJ59lD5kqfgWd0rR/q3QCTymkkVRQtUmrnj30GQMi8quza9i GvGdguBePjWYESFfI1PpR3WMU7BTjzov5Ti+CXYdNqbKwlBEcEyuZqtCarP2zdCtqAggSrme8eqKc 6elnP6RpJDG6GJMrwONHJttNL2hAU+fnlFEywsO7qDLLilkH9FBWycoDDhPOHOwIUghWOnZPNsK3s spnmzzw70ePKYg==; Original-Received: from [87.69.77.57] (port=2320 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGzKX-0004PK-Q1; Thu, 28 Jul 2022 04:57:21 -0400 In-Reply-To: <87bkt98wju.fsf@cassou.me> (message from Damien Cassou on Thu, 28 Jul 2022 10:35:01 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238087 Archived-At: > From: Damien Cassou > Cc: 56809@debbugs.gnu.org > Date: Thu, 28 Jul 2022 10:35:01 +0200 > > Eli Zaretskii writes: > > Looks OK? > > looks better than my version :-). The only thing I don't really like is > > > "Return FILENAME modified to… > > Most readers will know that FILENAME is not going to be modified but the > phrasing is still confusing in my opinion. Why confusing? And what do you mean by "will know that FILENAME is not going to be modified"? > I would prefer a version > around the word "concatenate" or similar. Here is another version: > > Concatenate FILENAME without its extension and EXTENSION. I don't want to say how the function does its job: that's not what a doc string should describe. ("Concatenate" is also inaccurate, because if EXTENSION lacks the leading period, that's not really what's going on there.) So please help me understand why "modified" is problematic, and let's take it from there. Thanks.