From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good Date: Tue, 09 Aug 2022 21:16:56 +0300 Message-ID: <837d3hth7r.fsf@gnu.org> References: <83tu6ltlcq.fsf@gnu.org> <87y1vxwe0y.fsf@gnus.org> <83k07htjxf.fsf@gnu.org> <87o7wtwcu9.fsf@gnus.org> <83fsi5tj31.fsf@gnu.org> <87k07hwbgs.fsf@gnus.org> <838rnxti1k.fsf@gnu.org> <878rnxwayl.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5372"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57079@debbugs.gnu.org, stefan@marxist.se To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 09 20:18:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLToF-0001EC-G6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 20:18:31 +0200 Original-Received: from localhost ([::1]:48400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLToE-0003xx-3Y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Aug 2022 14:18:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLTnm-0003xc-6x for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 14:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55117) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLTnl-00050u-TE for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 14:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLTnl-0006dB-MQ for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 14:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Aug 2022 18:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57079 X-GNU-PR-Package: emacs Original-Received: via spool by 57079-submit@debbugs.gnu.org id=B57079.166006903625437 (code B ref 57079); Tue, 09 Aug 2022 18:18:01 +0000 Original-Received: (at 57079) by debbugs.gnu.org; 9 Aug 2022 18:17:16 +0000 Original-Received: from localhost ([127.0.0.1]:44866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTn2-0006cD-D9 for submit@debbugs.gnu.org; Tue, 09 Aug 2022 14:17:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTmz-0006by-8g for 57079@debbugs.gnu.org; Tue, 09 Aug 2022 14:17:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLTmt-0004xs-Sw; Tue, 09 Aug 2022 14:17:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=J5HpsUv7+1DYS2NImmX3n8NP2+ERF4d8HMpDMC4B6Oc=; b=S8iG/N8BMheG SSPUCPuZ+I6He1mGYhWQ7oiX/bmUAGBRTr1k3vNpwYzS3JWdiJbkbnASoqtFxy6BlSN/OvquCxzN/ KYjs2S7enRLPPBR4p/rY3qoNtNh/TpfaNQIFFZrLGA1ECIVvU2MKiitolru/KuyPUvYe+ccnrqFAx Xfirk6v/erACq4daRUPwbIACfj1LaFomLNOo8Y7B5v6N9gnOqgPX3BlH52faS5LaI3MiLiVrWWjns /+L8BoimbX2Td39i+Ypm5Y8IG2CsqRl/5n5uvKet3J6u9+0AklpfXGuXNhsOvZrbQZL1zq3cuq0Lr dFtUmm/dV7rWwsiegoa31w==; Original-Received: from [87.69.77.57] (port=3712 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLTmt-0007gW-AI; Tue, 09 Aug 2022 14:17:07 -0400 In-Reply-To: <878rnxwayl.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 09 Aug 2022 20:03:46 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239189 Archived-At: > From: Lars Ingebrigtsen > Cc: stefan@marxist.se, 57079@debbugs.gnu.org > Date: Tue, 09 Aug 2022 20:03:46 +0200 > > Eli Zaretskii writes: > > > My point is that it will never be as fast as the implementations > > Stefan deleted, replacing them with seq-uniq. My point is that those > > changes just made several places in Emacs slower, even after your > > speedup, for no good reason. Those deleted functions, if they needed > > to be deleted, should have been replaced by a different > > implementation, which doesn't support TESTFN and is therefore faster, > > as the original implementations, now deleted, were. > > The performance of the new seq-uniq (called with no TESTFN) is identical > to the old gnus-delete-duplicates -- it's the same code. Yes, and delete-dups on a copy is faster.