From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57150: 29.0.50; [PATCH] Add test coverage for overlay modification hooks Date: Wed, 17 Aug 2022 14:51:26 +0300 Message-ID: <837d37dr5t.fsf@gnu.org> References: <87ilmygjyv.fsf@rfc20.org> <878rns946i.fsf@localhost> <87zgg7fyb8.fsf@rfc20.org> <87y1vqxhw2.fsf@localhost> <83mtc5iw80.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35410"; mail-complaints-to="usenet@ciao.gmane.io" Cc: matt@rfc20.org, yantar92@gmail.com, 57150@debbugs.gnu.org To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 17 14:00:06 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oOHiP-0008zY-QU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 14:00:05 +0200 Original-Received: from localhost ([::1]:47958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOHiO-00053l-Ms for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Aug 2022 08:00:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOHac-00063h-IS for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 07:52:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOHac-0002Ld-7e for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 07:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oOHac-0007li-0O for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2022 07:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2022 11:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57150-submit@debbugs.gnu.org id=B57150.166073710829843 (code B ref 57150); Wed, 17 Aug 2022 11:52:01 +0000 Original-Received: (at 57150) by debbugs.gnu.org; 17 Aug 2022 11:51:48 +0000 Original-Received: from localhost ([127.0.0.1]:49667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOHaO-0007lH-5v for submit@debbugs.gnu.org; Wed, 17 Aug 2022 07:51:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOHaK-0007ky-En for 57150@debbugs.gnu.org; Wed, 17 Aug 2022 07:51:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOHaE-0002Jm-Nq; Wed, 17 Aug 2022 07:51:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EiAGd3YmcDEdTwUa3Eo1Xc2qfR311h70q6xICjMws0o=; b=q5q9sTIDMkJZ lvKuqOrcTxmg3/isPjQBZ31GJ/50JzETMcbgV+oJRMA8tzB37biB6fzwygTAEfhNfuqacuQAAd6Ko PAsP3wGifzJVT5DSBoLHWyKgTttClNvpJFaMRLXue4Rgla7IgT45qMhHmK6yVo5aYAAsmaxIGjiRg emY1aPQqTtwG5kB8EpOqRd3VNu8hzcl8viQyFZk4ImEZJJYPa8EN7JOP1wCUTxDIBAHUnjZ/leE+w SYkFKftLV2CiLF6uFvXLSc92573U0SfoTq+2rwagyvEW25zGs/MiMOEzVSB4OmHW4A1MJuLbeoB5u iE7fx/syrKdHvmEZurD6VQ==; Original-Received: from [87.69.77.57] (port=4999 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOHaB-0005mp-Nl; Wed, 17 Aug 2022 07:51:36 -0400 In-Reply-To: (message from Richard Stallman on Tue, 16 Aug 2022 22:50:38 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240058 Archived-At: > From: Richard Stallman > Cc: yantar92@gmail.com, matt@rfc20.org, 57150@debbugs.gnu.org > Date: Tue, 16 Aug 2022 22:50:38 -0400 > > > The problems with overlays in Emacs are much wider than just Org. Our > > performance sucks in many cases because of that. Just two examples > > that were mentioned lately in the "long-line optimizations" > > discussion: show-paren-mode and isearch-lazy-highlight -- each one of > > these two is capable of literally bringing Emacs to its knees, > > response-time wise. > > The first question is, should these use text properties instead of > overlays? Text properties are less convenient when used for ephemeral highlighting. > Are they using many overlays to highlight many potential matches in a > long buffer? isearch-lazy-highlight does. > If so, would it make sense to show, at any time, only those > that are near point? When you move to a far-away part of the buffer, > it could add highlighting to the matches near there. But maybe it > can avoid ever trying to highlight more than a few parts of the buffer. isearch.el already attempts to do that, but its method of detecting what's out of the window doesn't work under truncate-lines.