unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#58605: 29.0.50; Commit 2a2f5530fa2 breaks ldap-search-internal
@ 2022-10-18  6:05 Jens Lechtenboerger
  2022-10-18 14:17 ` Eli Zaretskii
  2022-10-20  8:12 ` Juri Linkov
  0 siblings, 2 replies; 14+ messages in thread
From: Jens Lechtenboerger @ 2022-10-18  6:05 UTC (permalink / raw)
  To: 58605

Hi there,

commit 2a2f5530fa230e2b994be5683e63763833bb6a0a breaks
ldap-search-internal for searches with empty results.

Consider this search with ldapsearch, returning an empty result:

ldapsearch -h ldap.pca.dfn.de -tt -x -b O=DFN-Verein,C=DE \
'(mail=x@example.org)' userCertificate
# extended LDIF
#
# LDAPv3
# base <O=DFN-Verein,C=DE> with scope subtree
# filter: (mail=x@example.org)
# requesting: userCertificate 
#

# search result
search: 2
result: 0 Success

# numResponses: 1

The problem is that ldap-search-internal interprets the 2 in line
"search: 2" as filename with a certificate, bound to variable value.
Thus, (insert-file-contents-literally value) results in an error:
File is missing: "Opening input file", "Datei oder Verzeichnis nicht
gefunden", "[currentdir]/2"

Execute that:
(let ((ldap-default-base "O=DFN-Verein,C=DE")
      (ldap-ldapsearch-args '("-x" "-tt" "-H ldaps://ldap.pca.dfn.de"))
      (search-plist '(host "" filter "mail=x@example.org" attributes ("userCertificate") attrsonly nil withdn nil)))
  (ldap-search-internal search-plist))

Previously, that returned nil, after the mentioned commit it
produces the above error.

The added “?” should be removed there again:

@@ -699,7 +699,7 @@ ldap-search-internal
 	  (forward-line 1)
           (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\
 \\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\
-\\(<[\t ]*file://\\)\\(.*\\)$")
+\\(<[\t ]*file://\\)?\\(.*\\)$")
 	    (setq name (match-string 1)
 		  value (match-string 4))
             ;; Need to handle file:///D:/... as generated by OpenLDAP

Thanks
Jens





^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2022-10-26 13:20 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-18  6:05 bug#58605: 29.0.50; Commit 2a2f5530fa2 breaks ldap-search-internal Jens Lechtenboerger
2022-10-18 14:17 ` Eli Zaretskii
2022-10-20  8:12 ` Juri Linkov
2022-10-20 17:58   ` Filipp Gunbin
2022-10-21  6:25     ` Jens Lechtenboerger
2022-10-21 15:16       ` Filipp Gunbin
2022-10-22  9:43         ` Jens Lechtenboerger
2022-10-24 16:06           ` Filipp Gunbin
2022-10-25  5:55             ` Jens Lechtenboerger
2022-10-25 13:12               ` Filipp Gunbin
2022-10-25 13:42                 ` Jens Lechtenboerger
2022-10-25 15:07                   ` Filipp Gunbin
2022-10-26  6:07                     ` Jens Lechtenboerger
2022-10-26 13:20                       ` Filipp Gunbin

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).