From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: arstoffel@gmail.com, 58447@debbugs.gnu.org
Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history
Date: Thu, 27 Oct 2022 16:15:53 +0300 [thread overview]
Message-ID: <837d0lmmpi.fsf@gnu.org> (raw)
In-Reply-To: <42bb91a0-60ff-2e51-dcdc-c1e1f80e31ec@yandex.ru> (message from Dmitry Gutov on Thu, 27 Oct 2022 11:44:09 +0300)
> Date: Thu, 27 Oct 2022 11:44:09 +0300
> Cc: 58447@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
>
> On 26.10.2022 12:04, Augusto Stoffel wrote:
> > I'm copying Dmitry.
>
> Hi!
>
> > On Tue, 11 Oct 2022 at 22:13, Eli Zaretskii wrote:
> >
> >>> From: Augusto Stoffel<arstoffel@gmail.com>
> >>> Date: Tue, 11 Oct 2022 20:29:24 +0200
> >>>
> >>> `project-find-file' and related commands share their history with more
> >>> general commands like `find-file', so they should add the absolute file
> >>> name to history. Currently, file names relative to the project root are
> >>> added. The attached patch fixes this.
> >> Shouldn't project.el have its separate history of file names,
> > I'm not sure that's useful, but then the history items should be
> > absolute file names anyway.
> >
> >> perhaps even a project-specific history?
> > This might make sense.
>
> I like both of these ideas, except I'm not sure how to implement the
> project-specific part better.
>
> I suppose we won't be passing the history var to completing-read anymore?
I thought about a project-specific history variable.
next prev parent reply other threads:[~2022-10-27 13:15 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 18:29 bug#58447: [PATCH] In project-find-file, add absolute file name to history Augusto Stoffel
2022-10-11 19:13 ` Eli Zaretskii
2022-10-26 9:04 ` Augusto Stoffel
2022-10-27 8:44 ` Dmitry Gutov
2022-10-27 13:15 ` Eli Zaretskii [this message]
2022-10-27 14:21 ` Dmitry Gutov
2022-10-27 14:26 ` Augusto Stoffel
2022-10-27 15:36 ` Dmitry Gutov
2022-10-27 15:56 ` Augusto Stoffel
2022-10-27 16:07 ` Dmitry Gutov
2022-10-27 15:52 ` Eli Zaretskii
2022-10-27 16:10 ` Dmitry Gutov
2022-10-27 16:37 ` Augusto Stoffel
2022-10-27 16:48 ` Dmitry Gutov
2022-10-27 16:53 ` Augusto Stoffel
2022-10-27 17:34 ` Dmitry Gutov
2022-10-27 17:48 ` Augusto Stoffel
2022-10-27 18:05 ` Dmitry Gutov
2022-10-27 18:12 ` Augusto Stoffel
2022-10-27 19:51 ` Dmitry Gutov
2022-10-27 19:41 ` Juri Linkov
2022-10-28 18:11 ` Dmitry Gutov
2022-10-29 17:45 ` Juri Linkov
2022-10-30 19:42 ` Dmitry Gutov
2022-10-31 8:06 ` Augusto Stoffel
2022-11-01 17:30 ` Juri Linkov
2022-11-01 22:14 ` Dmitry Gutov
2022-11-18 16:28 ` Augusto Stoffel
2022-11-25 13:39 ` Eli Zaretskii
2022-11-26 2:28 ` Dmitry Gutov
2022-11-28 22:58 ` Augusto Stoffel
2022-11-29 16:29 ` Dmitry Gutov
2022-12-09 7:38 ` Juri Linkov
2022-12-09 13:00 ` Dmitry Gutov
2022-12-10 17:27 ` Juri Linkov
2022-12-10 19:50 ` Dmitry Gutov
2022-12-11 17:57 ` Juri Linkov
2022-12-11 18:14 ` Dmitry Gutov
2022-12-12 17:41 ` Juri Linkov
2022-12-12 18:49 ` Augusto Stoffel
2022-12-13 17:28 ` Juri Linkov
2022-12-14 16:47 ` Augusto Stoffel
2022-12-14 18:45 ` Dmitry Gutov
2022-12-14 19:32 ` Augusto Stoffel
2022-12-14 23:04 ` Dmitry Gutov
2022-12-15 7:24 ` Juri Linkov
2022-12-15 11:07 ` Augusto Stoffel
2022-12-15 14:04 ` Dmitry Gutov
2022-12-15 13:54 ` Dmitry Gutov
2022-12-15 17:24 ` Juri Linkov
2022-12-15 22:20 ` Dmitry Gutov
2022-12-16 7:48 ` Juri Linkov
2022-12-18 0:32 ` Dmitry Gutov
2022-12-15 11:07 ` Augusto Stoffel
2022-12-15 14:08 ` Dmitry Gutov
2022-12-15 17:21 ` Juri Linkov
2022-12-15 22:50 ` Dmitry Gutov
2022-12-18 8:36 ` Juri Linkov
2022-12-18 11:51 ` Dmitry Gutov
2022-12-19 17:55 ` Juri Linkov
2022-12-19 18:01 ` Eli Zaretskii
2022-12-19 19:48 ` Juri Linkov
2022-12-19 20:00 ` Eli Zaretskii
2022-12-19 19:18 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837d0lmmpi.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58447@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).