From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Date: Sun, 30 Oct 2022 20:02:54 +0200 Message-ID: <837d0hfaup.fsf@gnu.org> References: <17965.1667151624@alto> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38018"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 19:04:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opCfP-0009ba-3C for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 19:04:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opCfD-0005pn-UU; Sun, 30 Oct 2022 14:04:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opCfC-0005pf-EX for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 14:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opCfC-0002oQ-7Y for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 14:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1opCfB-0003hB-OR for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 14:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 18:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58721 X-GNU-PR-Package: emacs Original-Received: via spool by 58721-submit@debbugs.gnu.org id=B58721.166715300114155 (code B ref 58721); Sun, 30 Oct 2022 18:04:01 +0000 Original-Received: (at 58721) by debbugs.gnu.org; 30 Oct 2022 18:03:21 +0000 Original-Received: from localhost ([127.0.0.1]:38998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opCeX-0003gF-5e for submit@debbugs.gnu.org; Sun, 30 Oct 2022 14:03:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opCeU-0003g0-Vy for 58721@debbugs.gnu.org; Sun, 30 Oct 2022 14:03:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opCeP-0002cP-BW; Sun, 30 Oct 2022 14:03:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=R5ERU2j1a/tVO09FxLm7xVLyiz1Zl2lfpYmgm5SDEls=; b=Uu88DO576/2r E+IHrfg2qmUWOVoJKTaojzM58fpLU2w5ol4LhGPvsLG26BSjWp5A4pA8GQGAkNRP/FjrFccSONMo0 x7c6TCuOKsARBNNK/hSsds74U1HP7xdBLq7GNTcd2ukRpOfsZ9R+uygiZCjC0htW73aqPwr+Mww3x KUh4ggVYD9KXkw6ecRzE3/CSPZcJIQ6iBnAyYHdY4VaqXue7b74JpvSp01nfUZmG4ERctfezxFzjD HJCRZZ+q/YOQl6beOv54NLP3k2fJbbEPksjpwQdkZiMqGDIEqcn3n6kYD8Axw79CpKABu8BS1wFTY KvRloIn+HIa9xXJ1HXMqgQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opCeO-0006Sh-P7; Sun, 30 Oct 2022 14:03:13 -0400 In-Reply-To: <17965.1667151624@alto> (message from Mike Kupfer on Sun, 30 Oct 2022 10:40:24 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246642 Archived-At: > From: Mike Kupfer > cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com > Date: Sun, 30 Oct 2022 10:40:24 -0700 > > Eli Zaretskii wrote: > > > I just thought you'd be able to call copy-directory, similarly (but > > differently) to what rename-file does, instead of using your > > lambda-function. > > Ah, of course. Thanks, yes, that's cleaner. How does the attached > patch look? Looks good, but maybe add to the comment the reason _why_ we don't use rename-file for directories. You explained _what_ we do, but not _why_. Thanks.