unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Brian Leung <leungbk@posteo.net>
Cc: benjamin@orthen.net, 60198@debbugs.gnu.org, joaotavora@gmail.com
Subject: bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver
Date: Tue, 20 Dec 2022 16:32:39 +0200	[thread overview]
Message-ID: <837cymcfi0.fsf@gnu.org> (raw)
In-Reply-To: <871qoufjv8.fsf@posteo.net> (message from Brian Leung on Tue, 20 Dec 2022 10:25:14 +0000)

> Cc: Benjamin Orthen <benjamin@orthen.net>, 60198@debbugs.gnu.org
> From: Brian Leung <leungbk@posteo.net>
> Date: Tue, 20 Dec 2022 10:25:14 +0000
> 
> 
> João Távora <joaotavora@gmail.com> writes:
> 
> > OK with me.  Are we sure that we can't just have one of them? 
> > Maybe
> > those other distributions which create the "language-server" 
> > variety 
> > _also_ create the "languageserver" version? Anyway, again, looks
> > ok to me, but let's try not to get too slippery on this slope.
> > Sometimes a misspelling is just a misspelling and we shouldn't
> > help perpetuate it.
> >
> > João
> 
> See 
> https://github.com/nixos/nixpkgs/blob/6844c91781fdad8ad523b77ec9d1f35ff407a8e6/pkgs/development/node-packages/node-packages.json#L383-L387.
> 
> It appears that there are no executables named 
> vscode-{css,html}-languageserver, so the only way of accessing 
> those corresponding executables (at least in Nix) is via 
> nodePackages.vscode-langservers-extracted, which provides 
> vscode-{css,html,json}-language-server. Meanwhile, 
> vscode-{css,html}-languageserver-bin are already accounted for in 
> eglot-server-programs via the executables 
> {css,html}-languageserver.
> 
> So I think we should keep support for the "language-server" 
> variants as well.

Thanks, so I've now installed your patch on the emacs-29 branch, and
I'm closing this bug.





  reply	other threads:[~2022-12-20 14:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 10:13 bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver Benjamin Orthen
2022-12-19 12:42 ` Brian Leung
2022-12-19 13:00   ` Eli Zaretskii
2022-12-19 23:07     ` Brian Leung
2022-12-20  3:36       ` Eli Zaretskii
2022-12-20 10:21         ` Brian Leung
2022-12-19 14:17   ` Benjamin Orthen
2022-12-19 23:04     ` Brian Leung
2022-12-20  1:12       ` João Távora
2022-12-20 10:25         ` Brian Leung
2022-12-20 14:32           ` Eli Zaretskii [this message]
2023-09-05 23:51             ` Stefan Kangas
2022-12-19 12:53 ` Eli Zaretskii
2022-12-19 14:19   ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837cymcfi0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60198@debbugs.gnu.org \
    --cc=benjamin@orthen.net \
    --cc=joaotavora@gmail.com \
    --cc=leungbk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).