unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 62578@debbugs.gnu.org
Subject: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell
Date: Sun, 02 Apr 2023 08:29:27 +0300	[thread overview]
Message-ID: <837cuuyhqg.fsf@gnu.org> (raw)
In-Reply-To: <aeb20c5c-68d1-efa5-97c5-b869d6acf153@gmail.com> (message from Jim Porter on Sat, 1 Apr 2023 17:58:59 -0700)

> Date: Sat, 1 Apr 2023 17:58:59 -0700
> From: Jim Porter <jporterbugs@gmail.com>
> Cc: 62578@debbugs.gnu.org
> 
> On 4/1/2023 12:40 AM, Jim Porter wrote:
> > My only concern there is making Emacs do something reasonable when 
> > piping data into it, but I can just try a few things out, and if it 
> > really doesn't work, the existing tests in my patch are hopefully still 
> > better than nothing.
> 
> Ok, that wasn't too hard. How does this look?

LGTM, thanks.

One minor nit: 'message' in a batch session prints to stderr, not to
stdout.





  reply	other threads:[~2023-04-02  5:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-01  4:41 bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell Jim Porter
2023-04-01  6:07 ` Eli Zaretskii
2023-04-01  7:16   ` Jim Porter
2023-04-01  7:22     ` Eli Zaretskii
2023-04-01  7:40       ` Jim Porter
2023-04-02  0:58         ` Jim Porter
2023-04-02  5:29           ` Eli Zaretskii [this message]
2023-04-02  5:51             ` Jim Porter
2023-04-02 21:25               ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837cuuyhqg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=62578@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).