From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62959: [PATCH] Recognize defstruct slot names in various eieio functions Date: Wed, 03 May 2023 14:47:10 +0300 Message-ID: <837ctpmybl.fsf@gnu.org> References: <87o7njv7qh.fsf@gmail.com> <83cz3z6o8p.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15500"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62959-done@debbugs.gnu.org, thuna.cing@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 03 13:47:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puAx8-0003nw-AT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 May 2023 13:47:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puAws-0004gm-5R; Wed, 03 May 2023 07:47:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puAwp-0004gV-Ca for bug-gnu-emacs@gnu.org; Wed, 03 May 2023 07:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puAwp-0006Wg-3v for bug-gnu-emacs@gnu.org; Wed, 03 May 2023 07:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puAwo-0000c6-Jd for bug-gnu-emacs@gnu.org; Wed, 03 May 2023 07:47:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 May 2023 11:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62959 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 62959@debbugs.gnu.org, eliz@gnu.org, thuna.cing@gmail.com Original-Received: via spool by 62959-done@debbugs.gnu.org id=D62959.16831144042327 (code D ref 62959); Wed, 03 May 2023 11:47:02 +0000 Original-Received: (at 62959-done) by debbugs.gnu.org; 3 May 2023 11:46:44 +0000 Original-Received: from localhost ([127.0.0.1]:45762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puAwW-0000bS-78 for submit@debbugs.gnu.org; Wed, 03 May 2023 07:46:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puAwS-0000bE-MD for 62959-done@debbugs.gnu.org; Wed, 03 May 2023 07:46:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puAwM-0006U6-9s; Wed, 03 May 2023 07:46:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ODUjnVHnvrDf9RrYzJfRhayIO2WeRcgDMU86uPWwFT0=; b=Z+dDOlQQuBrL G/EASJ5EbJLrhws+etlZAcJETHlF1S+qtLj5Hr36KIVkzHt+WL1qq7DQPazcxpRKQnjn4gIJSLu7J b79q5dplXrsN+QQvv3Pa7q0fwA9hosITcqRbJkNpJu8CwtWd5GAXqxk8qd1RfF1SdEkwBhSGoMYLJ GnQjnCWayc2b3swPiK5/SYq/9I47mojY6UFOftSC9zs/UWabzlzKmiZSE6kewm1NFwxqS81/x0Q80 LrAeASP5ZmzOOpLJC6OZh3J/IL2uG2gJoo+SM8qMG3wEvxQ34307Gm97/NueZDsufLw4VBt46vCNX efQOM+P6rL+y+8ZE+75WIA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puAwK-00056M-B7; Wed, 03 May 2023 07:46:33 -0400 In-Reply-To: (message from Stefan Monnier on Tue, 02 May 2023 16:48:02 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260974 Archived-At: > From: Stefan Monnier > Cc: Thuna , 62959@debbugs.gnu.org > Date: Tue, 02 May 2023 16:48:02 -0400 > > >> diff --git a/lisp/emacs-lisp/cl-preloaded.el b/lisp/emacs-lisp/cl-preloaded.el > >> index 9445093f143..5235be52996 100644 > >> --- a/lisp/emacs-lisp/cl-preloaded.el > >> +++ b/lisp/emacs-lisp/cl-preloaded.el > >> @@ -176,6 +176,7 @@ cl-struct-define > >> (i 0) > >> (offset (if type 0 1))) > >> (dolist (slot slots) > >> + (put (car slot) 'slot-name t) > >> (let* ((props (cl--plist-to-alist (cddr slot))) > >> (typep (assq :type props)) > >> (type (if (null typep) t > >> -- > >> 2.39.2 > >> > > > > Stefan, any comments? > > LGTM, thanks, Thanks, installed on the emacs-29 branch, and closing.