From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 62959-done@debbugs.gnu.org, thuna.cing@gmail.com
Subject: bug#62959: [PATCH] Recognize defstruct slot names in various eieio functions
Date: Wed, 03 May 2023 14:47:10 +0300 [thread overview]
Message-ID: <837ctpmybl.fsf@gnu.org> (raw)
In-Reply-To: <jwv4joujw9d.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Tue, 02 May 2023 16:48:02 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Thuna <thuna.cing@gmail.com>, 62959@debbugs.gnu.org
> Date: Tue, 02 May 2023 16:48:02 -0400
>
> >> diff --git a/lisp/emacs-lisp/cl-preloaded.el b/lisp/emacs-lisp/cl-preloaded.el
> >> index 9445093f143..5235be52996 100644
> >> --- a/lisp/emacs-lisp/cl-preloaded.el
> >> +++ b/lisp/emacs-lisp/cl-preloaded.el
> >> @@ -176,6 +176,7 @@ cl-struct-define
> >> (i 0)
> >> (offset (if type 0 1)))
> >> (dolist (slot slots)
> >> + (put (car slot) 'slot-name t)
> >> (let* ((props (cl--plist-to-alist (cddr slot)))
> >> (typep (assq :type props))
> >> (type (if (null typep) t
> >> --
> >> 2.39.2
> >>
> >
> > Stefan, any comments?
>
> LGTM, thanks,
Thanks, installed on the emacs-29 branch, and closing.
prev parent reply other threads:[~2023-05-03 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 22:15 bug#62959: [PATCH] Recognize defstruct slot names in various eieio functions Thuna
2023-04-20 6:50 ` Eli Zaretskii
2023-05-02 20:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-03 11:47 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837ctpmybl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62959-done@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=thuna.cing@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).