From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60418: [PATCH] Add :vc keyword to use-package Date: Sat, 06 May 2023 22:13:42 +0300 Message-ID: <837ctlff2x.fsf@gnu.org> References: <87zgb6uk2r.fsf@hyperspace> <87wn2bzvcp.fsf@hyperspace> <835y9vbyfr.fsf@gnu.org> <87mt36uwl8.fsf@hyperspace> <83ttxd8k1z.fsf@gnu.org> <87v8hrn56l.fsf@hyperspace> <87cz3w2lvb.fsf@posteo.net> <87jzy3ku6u.fsf@hyperspace> <87bkje93ou.fsf@posteo.net> <87y1mhihhy.fsf@hyperspace> <87ildbet2d.fsf@hyperspace> <831qjyoqj5.fsf@gnu.org> <87h6suolt2.fsf@hyperspace> <83ttwun4q4.fsf@gnu.org> <87o7n0fr9e.fsf@hyperspace> <878re3cqro.fsf@posteo.net> <83ild7jq5c.fsf@gnu.org> <87v8h7ba55.fsf@posteo.net> <83zg6ji806.fsf@gnu.org> <87wn1mlmwx.fsf@posteo.net> <83v8h6hb2q.fsf@gnu.org> <87wn1lguqt.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1368"; mail-complaints-to="usenet@ciao.gmane.io" Cc: soliditsallgood@mailbox.org, felician.nemeth@gmail.com, 60418@debbugs.gnu.org, stefankangas@gmail.com To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 06 21:14:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvNMF-00005c-16 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 May 2023 21:14:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvNM3-0006BH-V1; Sat, 06 May 2023 15:14:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvNM2-0006Ax-Ga for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 15:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvNM2-0008PI-8H for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 15:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvNM2-0004sc-3c for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.168340038218645 (code B ref 60418); Sat, 06 May 2023 19:14:02 +0000 Original-Received: (at 60418) by debbugs.gnu.org; 6 May 2023 19:13:02 +0000 Original-Received: from localhost ([127.0.0.1]:35780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvNL3-0004qY-Gb for submit@debbugs.gnu.org; Sat, 06 May 2023 15:13:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvNKy-0004qG-LP for 60418@debbugs.gnu.org; Sat, 06 May 2023 15:13:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvNKs-0008Fv-Do; Sat, 06 May 2023 15:12:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qL4DP9ZhvZf0SpIC6sjMyJ1Xjgi/qux1+Y24KmWqqQ0=; b=XCX4X0+YqSlV +/AWamVmTFR9hTFhMpblaAMuHCnaIzvGZ7bsa1nDg2cgAXU3pbKoSeZJK22E+lbZhkMKPIBLv3jU8 B8g76IjdMeoi8Ob1m4698snF/Yb/exm8664cTL+6HBBf1fYjgwvSS85JokqYTC+1Re3sYFwP27V00 SzPhmuA+EirdMDQ+Zg1OUdosMS3Ew03yGWCY9YoLt4/RnbOHMtTW0MFlLIZ34q4rwEmeM2BD+URXz v9Fnu/pNiLD4u0mKxGPLHPgnsTHvAfDove1vufBupuVvmdXNBPF6KD5rQLCoLcU+pGrEauM9yNK9d OvJdwueMJF+/uJRQd2/SWQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvNKo-0006aP-Ln; Sat, 06 May 2023 15:12:49 -0400 In-Reply-To: <87wn1lguqt.fsf@posteo.net> (message from Philip Kaludercic on Sat, 06 May 2023 18:50:02 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261213 Archived-At: > From: Philip Kaludercic > Cc: soliditsallgood@mailbox.org, 60418@debbugs.gnu.org, > felician.nemeth@gmail.com, stefankangas@gmail.com > Date: Sat, 06 May 2023 18:50:02 +0000 > > Eli Zaretskii writes: > > >> This is true, for package-vc-install, but the idea was not do this for > >> the :vc keyword to use-package. > > > > But I wrote the above as a comment to a patch to package-vc.el, not to > > use-package. So why use-package is relevant here? > > Because this patch is related to use-package, and a keyword that would > allow for use-package to invoke package-vc-install? Yes, but the doc string in package-vc-install should describe everything that package-vc supports, not just the subset we think will be useful in use-package via :rev. Anyway, I think we are in agreement, as your last doc string is comprehensive enough to make me happy.