unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: sbaugh@catern.com
Cc: 64425@debbugs.gnu.org
Subject: bug#64425: [PATCH] Mention minibuffer-next-completion in completion-help
Date: Sun, 02 Jul 2023 20:16:51 +0300	[thread overview]
Message-ID: <837crinsho.fsf@gnu.org> (raw)
In-Reply-To: <87y1jygtra.fsf@catern.com> (sbaugh@catern.com)

> From: sbaugh@catern.com
> Date: Sun, 02 Jul 2023 16:31:21 +0000 (UTC)
> 
> * lisp/simple.el (completion-list-mode-map): Bind
> minibuffer-{next,previous,choose}-completion.
> (completion-setup-function): Mention bindings for
> minibuffer-{next,previous,choose}-completion.
> ---
>  lisp/simple.el | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/lisp/simple.el b/lisp/simple.el
> index 406f1008df3..59e1311eb2b 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -9697,6 +9697,9 @@ completion-list-mode-map
>      (define-key map [right] 'next-completion)
>      (define-key map [?\t] 'next-completion)
>      (define-key map [backtab] 'previous-completion)
> +    (define-key map (kbd "M-<up>") 'minibuffer-previous-completion)
> +    (define-key map (kbd "M-<down>") 'minibuffer-next-completion)
> +    (define-key map (kbd "M-RET") 'minibuffer-choose-completion)
>      (define-key map "z" 'kill-current-buffer)
>      (define-key map "n" 'next-completion)
>      (define-key map "p" 'previous-completion)
> @@ -10093,8 +10096,8 @@ completion-setup-function
>  	(goto-char (point-min))
>  	(if (display-mouse-p)
>  	    (insert "Click on a completion to select it.\n"))
> -	(insert (substitute-command-keys
> -		 "In this buffer, type \\[choose-completion] to \
> +        (insert (substitute-command-keys
> +		 "Type \\[minibuffer-next-completion] and \\[minibuffer-previous-completion] to change completion, and \\[minibuffer-choose-completion] to \
>  select the completion near point.\n\n"))))))

Isn't this text too long for a single screen line?  If so, it will
cause an annoying "jumping" of the mode line.

Also, what about updating the documentation?





  reply	other threads:[~2023-07-02 17:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-02 16:31 bug#64425: [PATCH] Mention minibuffer-next-completion in completion-help sbaugh
2023-07-02 17:16 ` Eli Zaretskii [this message]
2023-07-02 19:14   ` sbaugh
2023-07-03 11:21     ` Eli Zaretskii
2023-07-03 12:53       ` Spencer Baugh
2023-07-03 13:16         ` Eli Zaretskii
     [not found] <4beb74b6-6bbc-4e0f-9b95-f95b7edf79b9@email.android.com>
2023-07-03 13:28 ` Eli Zaretskii
2023-07-03 13:31   ` Spencer Baugh
2023-07-03 13:43     ` Eli Zaretskii
2023-07-03 14:00       ` Spencer Baugh
2023-07-06  7:43         ` Eli Zaretskii
2023-07-06 13:00           ` Spencer Baugh
2023-07-08  9:53             ` Eli Zaretskii
     [not found] <e7933bfa-c6e1-4586-b9f0-8bc3555329ef@email.android.com>
2023-07-08 13:51 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837crinsho.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64425@debbugs.gnu.org \
    --cc=sbaugh@catern.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).