From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: felician.nemeth@gmail.com, philipk@posteo.net,
filippo.argiolas@gmail.com, 65418@debbugs.gnu.org
Subject: bug#65418: 29.1; Eglot: support clangd inactiveRegions extension
Date: Mon, 04 Sep 2023 15:44:34 +0300 [thread overview]
Message-ID: <837cp65cr1.fsf@gnu.org> (raw)
In-Reply-To: <CALDnm52sS7eG6j=6zfU65hfGmV-NhS7gaH8ntG-vQ-qc+kmDXA@mail.gmail.com> (message from João Távora on Mon, 4 Sep 2023 11:51:33 +0100)
> From: João Távora <joaotavora@gmail.com>
> Date: Mon, 4 Sep 2023 11:51:33 +0100
> Cc: Eli Zaretskii <eliz@gnu.org>, Felician Nemeth <felician.nemeth@gmail.com>, 65418@debbugs.gnu.org,
> Philip Kaludercic <philipk@posteo.net>
>
> On Mon, Sep 4, 2023 at 5:09 AM Filippo Argiolas
> <filippo.argiolas@gmail.com> wrote:
> >
> > On Mon, Sep 4, 2023 at 5:59 AM Filippo Argiolas
> > <filippo.argiolas@gmail.com> wrote:
> > >
> > > On Mon, Sep 4, 2023 at 3:06 AM João Távora <joaotavora@gmail.com> wrote:
> > > >
> > > > On Mon, Sep 4, 2023 at 2:05 AM João Távora <joaotavora@gmail.com> wrote:
> > > > >
> > > > > On Thu, Aug 31, 2023 at 6:28 PM Filippo Argiolas
> > > > > <filippo.argiolas@gmail.com> wrote:
> > > > > >
> > > > > > On Sun, Aug 27, 2023 at 3:58 PM João Távora <joaotavora@gmail.com> wrote:
> > > > > > > Glad to help. You're lucky I'm not some kind of wine connoisseur ;-)
> > > > > > > Make a patch for that (and remember to also include the exportation of
> > > > > > > the '--' symbols).
> > > > > > >
> > > > > >
> > > > > > Many thanks again! That code definitely made this work week more enjoyable ;-)
> > > > > >
> > > > > > Sorry for the delay with the patch, little time left these days for
> > > > > > side projects or even trivial contributions like this.
> > > > > > See if the attached patches could do!
> > > > >
> > > > > They were very helpful. I just pushed heavily edited versions of
> > > > > them to master. I used them as a starting point and credited you as
> > > > > co-author (I could have done the other way round, crediting myself
> > > > > as co-author, but the changes I did were a bit too extensive for
> > > > > that).
> > >
> > > No problem for me, edit as much as you want! just glad to help.
> > > I'd be just as happy if you just thanked me in the commit message.
> >
> > By the way I looked at your doc version and very much approve it. The
> > one about public API I think I don't even deserve co-authorship :-D
>
> It's mainly because i started by applying your patch then doing multiple
> changes to them.
>
> My intuition also tells me that the remnants of both your
> contribution are indeed "trivial" (as measured both in absolute LOC
> and complexity)
>
> But I admit I'm not fully aware of how these things are counted
> "officially", so better safe than sorry and I reverted them. But
> I would very much like to re-revert of course, as this was a lot
> of work and is a pretty valuable change, IMO. Let's wait for Eli to
> explain how to proceed.
To provide a helpful answer I need to know how much code was provided
by Filippo. Where can I see that?
next prev parent reply other threads:[~2023-09-04 12:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 8:41 bug#65418: 29.1; Eglot: support clangd inactiveRegions extension Filippo Argiolas
2023-08-21 16:57 ` Philip Kaludercic
2023-08-21 19:04 ` Felician Nemeth
2023-08-22 7:09 ` Filippo Argiolas
2023-08-22 8:56 ` João Távora
2023-08-22 11:02 ` Filippo Argiolas
2023-08-25 12:18 ` João Távora
2023-08-27 10:52 ` Filippo Argiolas
2023-08-27 14:01 ` João Távora
2023-08-31 17:28 ` Filippo Argiolas
2023-09-04 1:05 ` João Távora
2023-09-04 1:08 ` João Távora
2023-09-04 3:59 ` Filippo Argiolas
2023-09-04 4:09 ` Filippo Argiolas
2023-09-04 10:51 ` João Távora
2023-09-04 12:44 ` Eli Zaretskii [this message]
2023-09-04 12:49 ` João Távora
2023-09-04 16:17 ` Eli Zaretskii
2023-09-04 20:37 ` João Távora
2023-09-04 11:41 ` Eli Zaretskii
2023-09-02 8:14 ` Filippo Argiolas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837cp65cr1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65418@debbugs.gnu.org \
--cc=felician.nemeth@gmail.com \
--cc=filippo.argiolas@gmail.com \
--cc=joaotavora@gmail.com \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).