From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67946: 30.0.50; [RFC PATCH] Add an option to not report "Wrote ..." when saving recentf. Date: Tue, 26 Dec 2023 14:41:56 +0200 Message-ID: <837cl19luz.fsf@gnu.org> References: <87a5q41azk.fsf@laptop.lockywolf.net> <87wmt2505y.fsf@laptop.lockywolf.net> <834jg6bhaf.fsf@gnu.org> <87plyt4i6k.fsf@laptop.lockywolf.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32540"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67946@debbugs.gnu.org, stefankangas@gmail.com To: Vladimir Nikishkin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 26 13:43:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rI6mC-0008I6-Cf for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Dec 2023 13:43:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rI6ls-0007EA-Ln; Tue, 26 Dec 2023 07:42:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rI6lr-0007Dh-7J for bug-gnu-emacs@gnu.org; Tue, 26 Dec 2023 07:42:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rI6lq-0001RR-Uw for bug-gnu-emacs@gnu.org; Tue, 26 Dec 2023 07:42:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rI6lx-0006qX-PL for bug-gnu-emacs@gnu.org; Tue, 26 Dec 2023 07:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Dec 2023 12:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67946 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67946-submit@debbugs.gnu.org id=B67946.170359455426281 (code B ref 67946); Tue, 26 Dec 2023 12:43:01 +0000 Original-Received: (at 67946) by debbugs.gnu.org; 26 Dec 2023 12:42:34 +0000 Original-Received: from localhost ([127.0.0.1]:56074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rI6lV-0006pp-Ru for submit@debbugs.gnu.org; Tue, 26 Dec 2023 07:42:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rI6lT-0006pb-LA for 67946@debbugs.gnu.org; Tue, 26 Dec 2023 07:42:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rI6lG-0001NV-VG; Tue, 26 Dec 2023 07:42:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ds3HS3Qo7s/9584XC7+WnQb7FxeCPthu/l7kMpz7dU0=; b=OUkwLrxs0TpU 2tnmDbY3Y8GqueobAybV+d9TUWKkGawJaQP7ZslDULZw1fc1Hkdl/PYgSxO1xG206DT+um4V3KJ5u sZhbN6ZOK0lSLZ9lU/5oWpBGmZnjn2peqx2T8Y/Ej2ta4ikOvGofw42SjnSD36yX5USVm22MnQkZD 7seFKU/yf5hd3AtsLE/YpRSdvda8+1CQ/Wboz9nVaxLRtSnJLdPFiOZ0SIwdaDv5ZV3tzBmSUzAde ThuLEJrcljGdgGeDtcVDGMVPgWSprb1A8+ojP+NAWxz08kbPp0mbp2dyErbjcfSo44Q9psp82r/Sg sF3q0xmpteHStysEzWrMrQ==; In-Reply-To: <87plyt4i6k.fsf@laptop.lockywolf.net> (message from Vladimir Nikishkin on Tue, 26 Dec 2023 13:58:45 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276906 Archived-At: > From: Vladimir Nikishkin > Cc: Eli Zaretskii , 67946@debbugs.gnu.org > Date: Tue, 26 Dec 2023 13:58:45 +0800 > > Stefan Kangas writes: > > > Eli Zaretskii writes: > > > >> If we decide to turn it off, we will need a knob to revert to the old > >> behavior, because after so many years of the existing behavior, > >> someone somewhere might be used to it. > > > > I think the existing patch basically has that already, but it seems to > > be lacking a NEWS entry and a :version tag for the defcustom before it > > can go in. > > > > Vladimir, could you fix that and send a new patch? > > Added an entry to etc/NEWS, and, seems, fixed the actual verbosity > message printing condition. Thanks, a few minor comments: > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -1046,7 +1046,11 @@ desktop restoration to continue. > Similarly to buffer restoration by Desktop, 'recentf-mode' checking > of the accessibility of remote files can now time out if > 'remote-file-name-access-timeout' is set to a positive number. > - That empty separator line should not be deleted. > +*** New use option 'recentf-verbose'. ^^^ "user" > +By default 'recentf-save-list' prints a message when saving the > +recentf list. The new option, if set to nil, suppresses this message. ^^ Two spaces between sentences, please. > +If more debugging info suppression switches are to be added, this > +option might become more useful. I don't think we need this last sentence in NEWS. NEWS is about changes that are actually done, not about potential changes in the future. > +(defcustom recentf-verbose 1 > + "0 means to not show debugging messages related to the recentf machinery. > +1 means show messages that were printed by default on Emacs <= 29.1." A doc string should start with a single sentence that summarizes what the variable or function does. In this case, I suggest Whether to show verbose messages about low-level recentf actions. Also, if we are going to use an integer here, the variable should be called something like recentf-verbosity. Alternatively, we could make it a simple boolean, since we have no plans to extend it to more than 2 levels. > + :group 'recentf Do you need this :group tag? It shouldn't be needed in this case, I think. Finally, the commit log message is still missing.