From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#42147: 28.0.50; pure vs side-effect-free, missing optimizations? Date: Mon, 3 Aug 2020 17:07:35 +0200 Message-ID: <8371B1E5-F7DE-4CD6-977D-3D31B194C838@acm.org> References: <3A9CC2A3-8307-47B2-8D80-795C0AF020E1@acm.org> <0433A879-C98D-4B1A-B85C-A15DA9289099@acm.org> <1621669100.2102667.1593639091621@mail.yahoo.com> <33C2E2C8-16A6-47A9-B3A4-8A5F43648E04@acm.org> <51FE77F3-CA05-459A-9601-9E1EEBC1E2FE@acm.org> <1213DD41-01F9-4605-8D32-D750B6CE2B35@acm.org> <81F989D1-3CC4-450B-89D6-E9C16F766277@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33423"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani , Paul Eggert , Andrea Corallo , 42147@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 03 17:08:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2c4R-0008QE-Cs for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Aug 2020 17:08:11 +0200 Original-Received: from localhost ([::1]:52734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2c4P-0007fp-VL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Aug 2020 11:08:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2c4I-0007fZ-Nw for bug-gnu-emacs@gnu.org; Mon, 03 Aug 2020 11:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34318) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k2c4I-0001vg-EZ for bug-gnu-emacs@gnu.org; Mon, 03 Aug 2020 11:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k2c4I-0001xU-AM for bug-gnu-emacs@gnu.org; Mon, 03 Aug 2020 11:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Aug 2020 15:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42147 X-GNU-PR-Package: emacs Original-Received: via spool by 42147-submit@debbugs.gnu.org id=B42147.15964672797520 (code B ref 42147); Mon, 03 Aug 2020 15:08:02 +0000 Original-Received: (at 42147) by debbugs.gnu.org; 3 Aug 2020 15:07:59 +0000 Original-Received: from localhost ([127.0.0.1]:45864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2c4F-0001xD-Hm for submit@debbugs.gnu.org; Mon, 03 Aug 2020 11:07:59 -0400 Original-Received: from mail172c50.megamailservers.eu ([91.136.10.182]:58470 helo=mail33c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2c4B-0001wz-38 for 42147@debbugs.gnu.org; Mon, 03 Aug 2020 11:07:57 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1596467263; bh=4jwxYuyk70hNN68xUr9WS5t84n1TzuolTBZrnpeork8=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=HXvt9AFp6w0W8Kajgf5Buzn0hgXTGbjJVjsdcU82mmsYx2e4gsARsY0jR2ckp5VcD 0loNm89pJj9jhjlQ9dOT1Wf/eEAHjQk9P0ViOg0YfxbPE9/uXNbwLwdoIwzPJCZVUC 5D88k201QVEaFCd9sBdOC0fGrXrDW902zt96MKao= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 073F7ZiS028813; Mon, 3 Aug 2020 15:07:38 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.15) X-CTCH-RefID: str=0001.0A782F21.5F28283C.003F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=eaJDgIMH c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=iRZporoAAAAA:8 a=QO_HSIPmQ0wanQLc-skA:9 a=CjuIK1q_8ugA:10 a=NOBgFS-JBQ2l-kSd6-zu:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183945 Archived-At: 29 juli 2020 kl. 22.39 skrev Stefan Monnier : >=20 >> Regarding package-get-version: perhaps we should drop the 'pure' = property >> and just let callers wrap it in eval-when-compile? >=20 > I'd rather not: the benefit is too subtle, I'd expect most users won't > know/bother to use `eval-when-compile` around it even though I'd = expect > a vast majority of the uses can benefit from compile-time evaluation. > In contrast the cases where the impurity will get in the way > should be rare. Feel free to add a `save-match-data` if you think = it's > worth the trouble (but please include a comment explaining it's only > there in order to satisfy the `pure` annotation). Thank you, I'll let you make the decision since you introduced the = function. Another possibility would be to turn it into a macro again (or = more likely a macro that calls a function at compile-time), or use = define-inline.