From: Eli Zaretskii <eliz@gnu.org>
To: Damien Cassou <damien.cassou@gmail.com>
Cc: 16874@debbugs.gnu.org
Subject: bug#16874: 24.3.50; Regression in active window detection
Date: Tue, 25 Feb 2014 18:18:09 +0200 [thread overview]
Message-ID: <8361o317zy.fsf@gnu.org> (raw)
In-Reply-To: <87eh2rftna.fsf@gmail.com>
> From: Damien Cassou <damien.cassou@gmail.com>
> Date: Tue, 25 Feb 2014 10:06:49 +0100
>
>
> The following piece of code, from the milkypostman/powerline github
> repository, used to detect if the current window is active or not:
>
> (defun powerline-selected-window-active ()
> "Return whether the current window is active."
> (or (eq (frame-selected-window)
> (selected-window))
> (and (minibuffer-window-active-p
> (frame-selected-window))
> (eq (pl/minibuffer-selected-window)
> (selected-window)))))
>
> This works fine in released Emacs 24 but does not work anymore in
> emacs-snapshot (see below for details about the version I used to test).
> Is this an Emacs regression or a problem in the implementation of this
> function that is revealed by some recent changes in Emacs?
It's a deliberate change in Emacs that breaks functions which assume
that the window whose mode line is being redrawn is selected at that
time.
next prev parent reply other threads:[~2014-02-25 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 9:06 bug#16874: 24.3.50; Regression in active window detection Damien Cassou
2014-02-25 16:18 ` Eli Zaretskii [this message]
2014-02-25 16:28 ` Damien Cassou
2014-02-25 17:47 ` Eli Zaretskii
2014-02-26 10:16 ` martin rudalics
2014-03-07 6:31 ` Donald Curtis
2014-03-08 0:25 ` Stefan Monnier
2014-03-08 1:53 ` Donald Curtis
2014-03-18 22:18 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8361o317zy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=16874@debbugs.gnu.org \
--cc=damien.cassou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).