bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Konrad Podczeck]

Use the key combination C-x 5 2 to open a new frame. During creation of the new frame, there is an annoying flickering.

The flickering disappears, however, when tool-bar mode is disabled.

With or without toolbar-mode, there is no flickering during frame creation for emacs compiled with the option "--with-x".

So this flickering seems to be an NS-port specific bug.





In GNU Emacs 24.3.50.1 (x86_64-apple-darwin, NS apple-appkit-1038.36)
of 2014-03-09 on bob.porkrind.org
Repository revision: lekktu@gmail.com-20140308222620-e38x03628o8njfqq
Windowing system distributor `Apple', version 10.3.1138
Configured using:
`configure --host=x86_64-apple-darwin --build=i686-apple-darwin
--with-ns'

Important settings:
  locale-coding-system: utf-8-unix

Major mode: LaTeX

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> C-x C-f d o c u m a n t s <backspace> <backspace> 
<backspace> <backspace> e n t s / t e x f i l e s / 
b a l a t 2 - t e x <backspace> <backspace> <backspace> 
<backspace> . t e x <return> C-x C-f p u r i f . t 
e x <return> M-x f i n d - f i l e - o SPC SPC <help-echo> 
<down-mouse-2> <mouse-1> <down-mouse-1> <mouse-1> <menu-bar> 
<file> <new-file> C-x 5 2 <menu-bar> <help-menu> <
send-emacs-bug-report>

Recent messages:
Error: (file-error "Cannot open load file" "no such file or directory" "tex-site")
For information about GNU Emacs and the GNU system, type C-h C-a.
balat2.tex has auto save data; consider M-x recover-this-file
purif.tex has auto save data; consider M-x recover-this-file
Making completion list...
read-file-name-default: No file name specified [2 times]

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
help-fns mail-prsvr mail-utils help-mode tex-mode compile shell
pcomplete comint ansi-color ring latexenc info easymenu package
time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel ns-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment lisp-mode prog-mode register page menu-bar
rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process cocoa ns multi-tty emacs)

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Eli Zaretskii]

> Date: Sat, 29 Mar 2014 13:32:49 +0100
> From: Jan Djärv <jan.h.d@swipnet.se>
> 
> It is an extra redraw that happens only on NS, i.e. frame is fully drawn, then 
> cleared then redrawn again.  I'm not sure where it comes from yet.

Maybe someone sets the frame's garbaged flag?

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Jan Djärv]

Hello.

2014-03-29 13:56, Eli Zaretskii skrev:
>> Date: Sat, 29 Mar 2014 13:32:49 +0100
>> From: Jan Djärv <jan.h.d@swipnet.se>
>>
>> It is an extra redraw that happens only on NS, i.e. frame is fully drawn, then
>> cleared then redrawn again.  I'm not sure where it comes from yet.
>
> Maybe someone sets the frame's garbaged flag?
>

I made SET_FRAME_GARBAGED a no-op, it still does a double redraw.

	Jan D.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Eli Zaretskii]

> Date: Sat, 29 Mar 2014 14:16:04 +0100
> From: Jan Djärv <jan.h.d@swipnet.se>
> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
> 
> I made SET_FRAME_GARBAGED a no-op, it still does a double redraw.

Do you see 2 consecutive calls to update_window_tree?

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Eli Zaretskii]

> From: Konrad Podczeck <konrad.podczeck@univie.ac.at>
> Date: Sat, 29 Mar 2014 16:10:04 +0100
> 
> Maybe the following information gives some hint. Some days ago I looked 
> at the historical builds on http://emacsformacosx.com/builds/all, and 
> it seemed to me that the bug became manifest the first time in the 
> build made available at 2012-09-12.

When was the previous build?

Anyway, the only one near that date that looks relevant is revision
109972.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Konrad Podczeck]

The build before was made available at 2012-09-11. The revision numbers 
appearing in the diff-file of the build from 2012-09-11 do not contain 
109972, they range from 109976 to 109989


On 29.03.2014, at 16:08, Eli Zaretskii wrote:

>> From: Konrad Podczeck <konrad.podczeck@univie.ac.at>
>> Date: Sat, 29 Mar 2014 16:10:04 +0100
>>
>> Maybe the following information gives some hint. Some days ago I 
>> looked
>> at the historical builds on http://emacsformacosx.com/builds/all, and
>> it seemed to me that the bug became manifest the first time in the
>> build made available at 2012-09-12.
>
> When was the previous build?
>
> Anyway, the only one near that date that looks relevant is revision
> 109972.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Konrad Podczeck]

Sorry. I meant the revision number in the build from 2012-09-12, that 
showing the bug the first time.


On 29.03.2014, at 17:02, Konrad Podczeck wrote:

> The build before was made available at 2012-09-11. The revision 
> numbers appearing in the diff-file of the build from 2012-09-11 do not 
> contain 109972, they range from 109976 to 109989
>
>
> On 29.03.2014, at 16:08, Eli Zaretskii wrote:
>
>>> From: Konrad Podczeck <konrad.podczeck@univie.ac.at>
>>> Date: Sat, 29 Mar 2014 16:10:04 +0100
>>>
>>> Maybe the following information gives some hint. Some days ago I 
>>> looked
>>> at the historical builds on http://emacsformacosx.com/builds/all, and
>>> it seemed to me that the bug became manifest the first time in the
>>> build made available at 2012-09-12.
>>
>> When was the previous build?
>>
>> Anyway, the only one near that date that looks relevant is revision
>> 109972.
>

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Eli Zaretskii]

> Cc: Eli Zaretskii <eliz@gnu.org>,
>  16976@debbugs.gnu.org
> From: Konrad Podczeck <konrad.podczeck@univie.ac.at>
> Date: Sat, 29 Mar 2014 17:05:39 +0100
> 
> Sorry. I meant the revision number in the build from 2012-09-12, that 
> showing the bug the first time.
> 
> 
> On 29.03.2014, at 17:02, Konrad Podczeck wrote:
> 
> > The build before was made available at 2012-09-11. The revision 
> > numbers appearing in the diff-file of the build from 2012-09-11 do not 
> > contain 109972, they range from 109976 to 109989

Than perhaps 109984?

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Jan D.]

Eli Zaretskii skrev 2014-03-29 14:22:
>> Date: Sat, 29 Mar 2014 14:16:04 +0100
>> From: Jan Djärv <jan.h.d@swipnet.se>
>> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
>>
>> I made SET_FRAME_GARBAGED a no-op, it still does a double redraw.
>
> Do you see 2 consecutive calls to update_window_tree?
>

Well, it is difficult to tell as this function is called on mouse 
movement and on every key stroke and on every blink of the cursor.
But turning off blink cursor, and testing with and without toolbar gives 
3 calls.

	Jan D.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Jan D.]

Hello.

Konrad Podczeck skrev 2014-03-29 17:02:
> The build before was made available at 2012-09-11. The revision numbers
> appearing in the diff-file of the build from 2012-09-11 do not contain
> 109972, they range from 109976 to 109989

That implies 109984.  But reverting that does not help.

	Jan D.

>
>
> On 29.03.2014, at 16:08, Eli Zaretskii wrote:
>
>>> From: Konrad Podczeck <konrad.podczeck@univie.ac.at>
>>> Date: Sat, 29 Mar 2014 16:10:04 +0100
>>>
>>> Maybe the following information gives some hint. Some days ago I looked
>>> at the historical builds on http://emacsformacosx.com/builds/all, and
>>> it seemed to me that the bug became manifest the first time in the
>>> build made available at 2012-09-12.
>>
>> When was the previous build?
>>
>> Anyway, the only one near that date that looks relevant is revision
>> 109972.
>
>
>

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Eli Zaretskii]

> Date: Sat, 29 Mar 2014 17:28:42 +0100
> From: "Jan D." <jan.h.d@swipnet.se>
> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
> 
> Eli Zaretskii skrev 2014-03-29 14:22:
> >> Date: Sat, 29 Mar 2014 14:16:04 +0100
> >> From: Jan Djärv <jan.h.d@swipnet.se>
> >> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
> >>
> >> I made SET_FRAME_GARBAGED a no-op, it still does a double redraw.
> >
> > Do you see 2 consecutive calls to update_window_tree?
> >
> 
> Well, it is difficult to tell as this function is called on mouse 
> movement and on every key stroke and on every blink of the cursor.
> But turning off blink cursor, and testing with and without toolbar gives 
> 3 calls.

Maybe I'm missing something here, so let me take a step back.  You
said earlier that you see the frame cleared and redrawn.  I'm asking
if you can trace this clearing and redrawing to any of the calls to
update_frame or update_window_tree.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Jan D.]

Hello.

Eli Zaretskii skrev 2014-03-29 18:07:
>> Date: Sat, 29 Mar 2014 17:28:42 +0100
>> From: "Jan D." <jan.h.d@swipnet.se>
>> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
>>
>> Eli Zaretskii skrev 2014-03-29 14:22:
>>>> Date: Sat, 29 Mar 2014 14:16:04 +0100
>>>> From: Jan Djärv <jan.h.d@swipnet.se>
>>>> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
>>>>
>>>> I made SET_FRAME_GARBAGED a no-op, it still does a double redraw.
>>>
>>> Do you see 2 consecutive calls to update_window_tree?
>>>
>>
>> Well, it is difficult to tell as this function is called on mouse
>> movement and on every key stroke and on every blink of the cursor.
>> But turning off blink cursor, and testing with and without toolbar gives
>> 3 calls.
>
> Maybe I'm missing something here, so let me take a step back.  You
> said earlier that you see the frame cleared and redrawn.  I'm asking
> if you can trace this clearing and redrawing to any of the calls to
> update_frame or update_window_tree.
>

It seems the clearing is done because of an expose.
If we don't have a toolbar, NS thinks the frame is up to date when the 
event loop is entered after the first redisplay is done.

But if we have a toolbar NS thinks the frame is out of date and needs 
redrawing, thus sending an expose event (well, drawRect in NS speek) 
that does not happen without the toolbar.  So the clearing is already 
done when Emacs code is entered.

I don't know why we did not get this expose before, but much has 
happened, i.e. pixelwise resizing, event loop changes and more.

Maybe the generic code changed, because update_frame_tool_bar is called 
four times when a new frame is created.  NS does not have an 
"up-to-date" check on the toolbar, so it just recreates it.  This may be 
the cause.

	Jan D.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Eli Zaretskii]

> Date: Sat, 29 Mar 2014 18:52:45 +0100
> From: "Jan D." <jan.h.d@swipnet.se>
> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
> 
> It seems the clearing is done because of an expose.

Yes, that was my second suspect.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Jan D.]

Hello.

Eli Zaretskii skrev 2014-03-29 20:42:
>> Date: Sat, 29 Mar 2014 18:52:45 +0100
>> From: "Jan D." <jan.h.d@swipnet.se>
>> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
>>
>> It seems the clearing is done because of an expose.
>
> Yes, that was my second suspect.
>

I have checked in a fix in trunk that avoids redrawing until the tool 
bar is up to date.  Please try it.

	Jan D.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Darren Hoo]

"Jan D." <jan.h.d@swipnet.se> writes:

> Hello.
>
> Eli Zaretskii skrev 2014-03-29 20:42:
>>> Date: Sat, 29 Mar 2014 18:52:45 +0100
>>> From: "Jan D." <jan.h.d@swipnet.se>
>>> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
>>>
>>> It seems the clearing is done because of an expose.
>>
>> Yes, that was my second suspect.
>>
>
> I have checked in a fix in trunk that avoids redrawing until the tool
> bar is up to date.  Please try it.
>

The fix has problem when tool-bar is disabled at startup, ie, the
window won't change its size accordingly upon the frame resizing.

step to reproduce:

$ open Emacs.app --args -Q \
       -eval "(custom-set-variable'(tool-bar-mode nil))"

then try to resize the frame you'll see that the size of the buffer
window, the echo area all stay unchanged.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Jan D.]

Hello.

Darren Hoo skrev 2014-03-31 04:14:
> "Jan D." <jan.h.d@swipnet.se> writes:
>
>> Hello.
>>
>> Eli Zaretskii skrev 2014-03-29 20:42:
>>>> Date: Sat, 29 Mar 2014 18:52:45 +0100
>>>> From: "Jan D." <jan.h.d@swipnet.se>
>>>> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
>>>>
>>>> It seems the clearing is done because of an expose.
>>>
>>> Yes, that was my second suspect.
>>>
>>
>> I have checked in a fix in trunk that avoids redrawing until the tool
>> bar is up to date.  Please try it.
>>
>
> The fix has problem when tool-bar is disabled at startup, ie, the
> window won't change its size accordingly upon the frame resizing.
>
> step to reproduce:
>
> $ open Emacs.app --args -Q \
>         -eval "(custom-set-variable'(tool-bar-mode nil))"
>

eval: Symbol's function definition is void: custom-set-variable

> then try to resize the frame you'll see that the size of the buffer
> window, the echo area all stay unchanged.
>

Should be fixed now.

	Jan D.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Konrad Podczeck]

Thanks, Jan. Works. Big improvement.

Konrad Podczeck


Am 30.03.2014 um 19:22 schrieb Jan D.:

> Hello.
> 
> Eli Zaretskii skrev 2014-03-29 20:42:
>>> Date: Sat, 29 Mar 2014 18:52:45 +0100
>>> From: "Jan D." <jan.h.d@swipnet.se>
>>> CC: konrad.podczeck@univie.ac.at, 16976@debbugs.gnu.org
>>> 
>>> It seems the clearing is done because of an expose.
>> 
>> Yes, that was my second suspect.
>> 
> 
> I have checked in a fix in trunk that avoids redrawing until the tool bar is up to date.  Please try it.
> 
> 	Jan D.
> 

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Glenn Morris]

Is this a fix that should be in emacs-24?
The symptoms sounds like they could annoy many NS users.
I haven't understood if 24.3 had the same issue though.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Jan Djärv]

Hello.

31 mar 2014 kl. 19:51 skrev Glenn Morris <rgm@gnu.org>:

> 
> Is this a fix that should be in emacs-24?

I must check possible impact on GnuStep first.

> The symptoms sounds like they could annoy many NS users.
> I haven't understood if 24.3 had the same issue though.

It has.

	Jan D.

bug#16976: 24.3.50; Flickering during frame creation for the NS-port with toolbar-mode enabled

[Jan D.]

[-- Attachment #1: Type: text/plain, Size: 140 bytes --]

Hi.

> 31 mar 2014 kl. 19:51 skrev Glenn Morris <rgm@gnu.org>:
> 
> 
> Is this a fix that should be in emacs-24?

Backported.

     Jan D.


[-- Attachment #2: Type: text/html, Size: 540 bytes --]