unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 19307@debbugs.gnu.org
Subject: bug#19307: 24.4.51; Ellipsis created with `invisible' removes highlighting from overlay after-string after it
Date: Tue, 03 Feb 2015 20:54:55 +0200	[thread overview]
Message-ID: <8361bihlkw.fsf@gnu.org> (raw)
In-Reply-To: <54D0416E.7090507@yandex.ru>

> Date: Tue, 03 Feb 2015 05:33:02 +0200
> From: Dmitry Gutov <dgutov@yandex.ru>
> CC: 19307@debbugs.gnu.org
> 
>     This bug was introduced in Emacs 23, 10 years(!) ago.
> 
> Don't know your feelings on this subject, but I'm kinda proud. :)

You should be.

> > Now fixed in
> 
>     commit 27e11c0 on the emacs-24 branch.
> 
> Thanks, but it introduced a regression. Insert some text at the end, and "xxx" will get displayed twice:

Turns out the bug I fixed concealed another one that was also there
for a long time (more than 9 years), and became exposed due to my fix.
Now fixed in commit e589765 on the emacs-24 branch.

> Not to diminish your efforts, but I've noticed that the fix for each display problem I've reported lately involved move added lines than removed ones. Which looks like adding more special cases. That's worrying.

The bugs happened in special cases for which no one coded the
solution, so catering to those cases often needs additional code.
Isn't that natural?

Say you have something like

  int reckless_division = a / b;

and then someone reports a divide-by-zero crash, and you add
protection against b being zero -- won't you expect the code to grow a
little?

Anyway, you should be happier with this last fix, since it removes
more lines than it adds ;-)





  reply	other threads:[~2015-02-03 18:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 15:33 bug#19307: 24.4.51; Ellipsis created with `invisible' removes highlighting from overlay after-string after it Dmitry Gutov
     [not found] ` <handler.19307.B.1418052841706.ack@debbugs.gnu.org>
2015-02-02  3:47   ` bug#19307: Acknowledgement (24.4.51; Ellipsis created with `invisible' removes highlighting from overlay after-string after it) Dmitry Gutov
2015-02-02 16:29     ` bug#19307: 24.4.51; Ellipsis created with `invisible' removes highlighting from overlay after-string after it Eli Zaretskii
2015-02-03  3:33       ` Dmitry Gutov
2015-02-03 18:54         ` Eli Zaretskii [this message]
2015-02-03 20:30           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8361bihlkw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=19307@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).