unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ivan Shmakov <ivan@siamics.net>
Cc: 20522@debbugs.gnu.org
Subject: bug#20522: 25.0.50; ‘C-u C-x =’ output,	‘to input’ field
Date: Thu, 07 May 2015 18:37:41 +0300	[thread overview]
Message-ID: <836184qtyy.fsf@gnu.org> (raw)
In-Reply-To: <874mnoju5n.fsf_-_@violet.siamics.net>

> From: Ivan Shmakov <ivan@siamics.net>
> Date: Thu, 07 May 2015 15:15:32 +0000
> 
> 	Please consider the revised patch MIMEd.
> 
> 	* lisp/descr-text.el (describe-char): Show the exact C-x 8 RET
> 	invocation instead of a template.  (Bug#20522)
> 
> 	It was also requested in bug#20499 that a specific C-x 8
> 	(iso-transl) sequence is shown.  Yet I believe that deserves a
> 	separate patch.
> 
> -- 
> FSF associate member #7257  http://am-1.org/~ivan/      … 3013 B6A0 230E 334A
> 
> [2:text/diff Hide]
> 
> --- a/lisp/descr-text.el
> +++ b/lisp/descr-text.el
> @@ -618,7 +618,14 @@ defun describe-char (pos &optional buffer)
>                                     'help-args '(,current-input-method))
>  				 "input method")
>  			 (list
> -			  "type \"C-x 8 RET HEX-CODEPOINT\" or \"C-x 8 RET NAME\"")))))
> +                          (let ((name
> +                                 (or (get-char-code-property char 'name)
> +                                     (get-char-code-property char 'old-name))))
> +                            (if name
> +                                (format
> +                                 "type \"C-x 8 RET %x\" or \"C-x 8 RET %s\""
> +                                 char name)
> +                              (format "type \"C-x 8 RET %x\"" char))))))))
>                ("buffer code"
>                 ,(if multibyte-p
>                      (encoded-string-description

LGTM, thanks.





  reply	other threads:[~2015-05-07 15:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07  0:03 bug#20522: 25.0.50; `C-u C-x =' output, `to input' field Drew Adams
2015-05-07  7:10 ` bug#20522: 25.0.50; ‘C-u C-x =’ output, ‘to input’ field Ivan Shmakov
2015-05-07 14:45   ` Eli Zaretskii
2015-05-07 15:15     ` Ivan Shmakov
2015-05-07 15:37       ` Eli Zaretskii [this message]
2015-05-27 22:30         ` Ivan Shmakov
2015-05-07 15:55   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=836184qtyy.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=20522@debbugs.gnu.org \
    --cc=ivan@siamics.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).