unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: ".." <akml@163.com>
Cc: 21087@debbugs.gnu.org
Subject: bug#21087: 24.5; ff-find-other-file will create a file with an extra trailling	backslash
Date: Sat, 18 Jul 2015 20:40:52 +0300	[thread overview]
Message-ID: <83615h5pp7.fsf@gnu.org> (raw)
In-Reply-To: <7d5bec9d.dc4b.14ea1d91471.Coremail.akml@163.com>

> Date: Sat, 18 Jul 2015 23:47:15 +0800 (CST)
> From: ".." <akml@163.com>
> 
> It jumps out that ff-find-other-file will create the expecting file name with
> an extra
> trailling backslash, which makes the the newly opened buffer as directory.
> This happens after I updated all the 3rd party packages to the
> latest version. Although I havn't found out which package caused this
> issue, but the following patch will fix it, and I think it makes
> more sense to use read-file-name than read-directory-name
> 
> --- emacs\share\emacs\24.5\lisp\find-file.el
> +++ emacs\share\emacs\24.5\lisp\find-file.el
> @@ -495,7 +495,7 @@
> (setq name
> (expand-file-name
> - (read-directory-name
> + (read-file-name
> (format "Find or create %s in: " default-name)
> default-directory default-name nil)))

But that question is about the directory in which to create a file, so
read-directory-name sounds about right to me.





  reply	other threads:[~2015-07-18 17:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-18 15:47 bug#21087: 24.5; ff-find-other-file will create a file with an extra trailling backslash ..
2015-07-18 17:40 ` Eli Zaretskii [this message]
2015-07-19  2:44   ` bug#21087: 回复:Re: " ..
2015-07-20 15:32 ` Glenn Morris
2020-08-12  4:26   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83615h5pp7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=21087@debbugs.gnu.org \
    --cc=akml@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).