From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21468: 24.5; When next-line (visual) crosses overlay with before-string="\n" point goes to column 0 Date: Mon, 14 Sep 2015 16:33:30 +0300 Message-ID: <83613d9lcl.fsf@gnu.org> References: <834miybogz.fsf@gnu.org> <83zj0q9k0m.fsf@gnu.org> <83twqxa5is.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1442237663 31781 80.91.229.3 (14 Sep 2015 13:34:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Sep 2015 13:34:23 +0000 (UTC) Cc: 21468@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 14 15:34:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZbTtc-0001fW-Ff for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Sep 2015 15:34:12 +0200 Original-Received: from localhost ([::1]:40757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbTtb-0006dG-UZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Sep 2015 09:34:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbTtY-0006d4-8v for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 09:34:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbTtU-0004IG-89 for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 09:34:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbTtU-0004Hu-57 for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 09:34:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZbTtT-0006O0-ML for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 09:34:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Sep 2015 13:34:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21468-submit@debbugs.gnu.org id=B21468.144223762124519 (code B ref 21468); Mon, 14 Sep 2015 13:34:03 +0000 Original-Received: (at 21468) by debbugs.gnu.org; 14 Sep 2015 13:33:41 +0000 Original-Received: from localhost ([127.0.0.1]:59756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbTt6-0006NO-UP for submit@debbugs.gnu.org; Mon, 14 Sep 2015 09:33:41 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:40616) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbTt0-0006NA-Cu for 21468@debbugs.gnu.org; Mon, 14 Sep 2015 09:33:35 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NUO0000059W0H00@a-mtaout23.012.net.il> for 21468@debbugs.gnu.org; Mon, 14 Sep 2015 16:33:32 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NUO00MKT5NVS690@a-mtaout23.012.net.il>; Mon, 14 Sep 2015 16:33:31 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106525 Archived-At: > Date: Mon, 14 Sep 2015 08:46:57 -0400 > From: Noam Postavsky > Cc: 21468@debbugs.gnu.org > > On Mon, Sep 14, 2015 at 2:17 AM, Eli Zaretskii wrote: > > > > Of course: that's a line of text. Why is that a problem? (I have no > > idea what role is that thin line serving in Magit.) > > In this particular case, the overlays are delimiting a "magit region" > (consisting of whole logical lines touched by Emacs' region). This > means the thin line has to move with point, staying just ahead of it. What's wrong with marking the region with some special background color? Anyway, if you must use overlays here, by all means do, just try to avoid newlines in its strings, if you want reliable cursor movement across that overlay. Please understand: what you originally perceived as a "bug" was actually normal Emacs routine of placing point immediately after the end of the overlay string. It ended up in column zero because the overlay string ended in a newline. If there were no newline, the problem would not have happened. We now have special code in vertical-motion that caters to this specific scenario. That's why using such overlay strings should be discouraged: they tend to force us add similar special-case code all over the place. > Here is a demo, eval this in a buffer, then do set-mark-command and > move around a bit: What am I supposed to see? I see nothing that I don't see without this.