From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19547: Patch for this bug Date: Tue, 08 Nov 2016 22:40:07 +0200 Message-ID: <8360nxhfiw.fsf@gnu.org> References: <874ms03qj1.fsf@web.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1478637778 24600 195.159.176.226 (8 Nov 2016 20:42:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 8 Nov 2016 20:42:58 +0000 (UTC) Cc: 19547@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 08 21:42:53 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4DEH-0005JU-1k for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Nov 2016 21:42:49 +0100 Original-Received: from localhost ([::1]:35378 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4DEK-00016C-2S for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Nov 2016 15:42:52 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4DCc-0008S3-5P for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2016 15:41:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4DCY-0002cv-MP for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2016 15:41:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34647) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4DCY-0002cj-Ce for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2016 15:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c4DCY-0003Nj-5n for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2016 15:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2016 20:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19547-submit@debbugs.gnu.org id=B19547.147863764812973 (code B ref 19547); Tue, 08 Nov 2016 20:41:02 +0000 Original-Received: (at 19547) by debbugs.gnu.org; 8 Nov 2016 20:40:48 +0000 Original-Received: from localhost ([127.0.0.1]:50046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4DCK-0003NA-25 for submit@debbugs.gnu.org; Tue, 08 Nov 2016 15:40:48 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4DCI-0003Mx-8Z for 19547@debbugs.gnu.org; Tue, 08 Nov 2016 15:40:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4DC9-0002XI-Un for 19547@debbugs.gnu.org; Tue, 08 Nov 2016 15:40:41 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4DC9-0002XE-Rn; Tue, 08 Nov 2016 15:40:37 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3306 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c4DC7-00076h-TC; Tue, 08 Nov 2016 15:40:37 -0500 In-reply-to: (message from Reuben Thomas on Tue, 8 Nov 2016 18:28:28 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125492 Archived-At: > From: Reuben Thomas > Date: Tue, 8 Nov 2016 18:28:28 +0000 > > Further, at present it would not help helm to implement Eli's suggestion of a list of events for input-pending-p > to ignore, as Helm currently does not use that (it has a custom version of while-no-input that does not call > input-pending-p). The suggestion was not that specific. The idea was to let Lisp programs specify which special events they would like to consider as input. E.g., define a variable that holds a list of such events, and test the value of that variable in the same place where you propose to add yet another event to those ignored for the purposes of throw-on-input (IMO, the same list should be looked at in readable_events, which will then make input-pending-p consistent with while-no-input and any other similar functionality). It shouldn't be too hard to implement that, and we gain a certain peace of mind in that we don't have to worry about some hypothetical application that would like to do stuff differently from Helm. IOW, since this is going to go on master, I see no reason to hurry with a simple solution, and would prefer a slightly more complex one, but one that is more future-proof. Can you do that? Thanks.