From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18716: Patch for this bug Date: Fri, 02 Dec 2016 11:40:02 +0200 Message-ID: <8360n2oej1.fsf@gnu.org> References: <8761fm903w.fsf@sc3d.org> <83a8d9hh62.fsf@gnu.org> <83lgwsfntd.fsf@gnu.org> <83y40rdyku.fsf@gnu.org> <3cd1ba7a-1aa4-359c-a817-dac9b567157e@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1480671799 3700 195.159.176.226 (2 Dec 2016 09:43:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Dec 2016 09:43:19 +0000 (UTC) Cc: 18716@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 02 10:43:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCkN7-0008UX-9F for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 10:43:13 +0100 Original-Received: from localhost ([::1]:33416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCkNB-0002iH-3K for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Dec 2016 04:43:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCkL3-0001gt-CU for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 04:41:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCkL0-0003Qd-8a for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 04:41:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34101) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cCkL0-0003QV-4s for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 04:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cCkKz-0006Vy-JN for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 04:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2016 09:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18716 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18716-submit@debbugs.gnu.org id=B18716.148067160724969 (code B ref 18716); Fri, 02 Dec 2016 09:41:01 +0000 Original-Received: (at 18716) by debbugs.gnu.org; 2 Dec 2016 09:40:07 +0000 Original-Received: from localhost ([127.0.0.1]:49500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCkK7-0006Ue-A7 for submit@debbugs.gnu.org; Fri, 02 Dec 2016 04:40:07 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCkK6-0006U7-9n for 18716@debbugs.gnu.org; Fri, 02 Dec 2016 04:40:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCkJx-0002zg-M0 for 18716@debbugs.gnu.org; Fri, 02 Dec 2016 04:40:00 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCkJx-0002zH-I7; Fri, 02 Dec 2016 04:39:57 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1309 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCkJt-0007Y8-MK; Fri, 02 Dec 2016 04:39:54 -0500 In-reply-to: (message from Reuben Thomas on Mon, 28 Nov 2016 21:32:03 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126400 Archived-At: > From: Reuben Thomas > Date: Mon, 28 Nov 2016 21:32:03 +0000 > Cc: Eli Zaretskii , 18716@debbugs.gnu.org > > ​Thanks for the heads up, that's great news! It bothered me that there was no easy way to do this previously. > > ​I updated my patch so that dired-omit-case-fold is now a three-valued variable which defaults to 'filesystem, > and a helper function that checks (filename-case-sensitive-p dired-directory) when this value is used. > > I've added info and NEWS documentation for dired-omit-case-fold. Thanks, a few comments below. With those fixed, please push to master. > +@vindex dired-omit-case-fold > +@item dired-omit-case-fold > + > +Default: @code{filesystem} Please mention this value in the text that follows. > + Set to > +@code{nil} to be always case-sensitive, and @code{t} to be always > +case-sensitive. So which is it? ;-) > +++ > +** The new user variable 'dired-omit-case-fold' allows the > +case-sensitivity of dired-omit-mode to be configured. It defaults to ^^^^^^^^^^ Our terminology is "customized". Bonus points for avoiding passive tense altogether ("... allows customization of case-sensitivity ..."). > +(defcustom dired-omit-case-fold 'filesystem > + "Whether `dired-omit-mode' will use case-folding to match the > +regexp of files to omit. When nil, always be case-sensitive; when The first line of a doc string should be a complete sentence. > +(defun dired-omit-case-fold-p (dir) > + "Return t if, according to `dired-omit-case-fold', > + `dired-omit-mode' should use case folding to interpret its > + regexp in directory DIR." Likewise.