unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 18716@debbugs.gnu.org
Subject: bug#18716: Patch for this bug
Date: Fri, 02 Dec 2016 11:40:02 +0200	[thread overview]
Message-ID: <8360n2oej1.fsf@gnu.org> (raw)
In-Reply-To: <CAOnWdohamh42+sc7rtTT4_cQC4XedS2FBT59z1GAsp3=oM4Z9A@mail.gmail.com> (message from Reuben Thomas on Mon, 28 Nov 2016 21:32:03 +0000)

> From: Reuben Thomas <rrt@sc3d.org>
> Date: Mon, 28 Nov 2016 21:32:03 +0000
> Cc: Eli Zaretskii <eliz@gnu.org>, 18716@debbugs.gnu.org
> 
> ​Thanks for the heads up, that's great news! It bothered me that there was no easy way to do this previously.
> 
> ​I updated my patch so that dired-omit-case-fold is now a three-valued variable which defaults to 'filesystem,
> and a helper function that checks (filename-case-sensitive-p dired-directory) when this value is used.
> 
> I've added info and NEWS documentation for dired-omit-case-fold.

Thanks, a few comments below.  With those fixed, please push to
master.

> +@vindex dired-omit-case-fold
> +@item dired-omit-case-fold
> +
> +Default:  @code{filesystem}

Please mention this value in the text that follows.

> +                                                           Set to
> +@code{nil} to be always case-sensitive, and @code{t} to be always
> +case-sensitive.

So which is it? ;-)

>  +++
> +** The new user variable 'dired-omit-case-fold' allows the
> +case-sensitivity of dired-omit-mode to be configured.  It defaults to
                                             ^^^^^^^^^^
Our terminology is "customized".

Bonus points for avoiding passive tense altogether ("... allows
customization of case-sensitivity ...").

> +(defcustom dired-omit-case-fold 'filesystem
> +  "Whether `dired-omit-mode' will use case-folding to match the
> +regexp of files to omit.  When nil, always be case-sensitive; when

The first line of a doc string should be a complete sentence.

> +(defun dired-omit-case-fold-p (dir)
> +  "Return t if, according to `dired-omit-case-fold',
> +  `dired-omit-mode' should use case folding to interpret its
> +  regexp in directory DIR."

Likewise.





  reply	other threads:[~2016-12-02  9:40 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14 14:50 bug#18716: 24.3; dired-omit-extensions's default value omits COPYING.LIB Reuben Thomas
2014-10-14 23:41 ` Stefan Monnier
2014-10-14 23:51   ` Reuben Thomas
2014-10-15  7:56   ` Andreas Schwab
2014-10-15 14:21     ` Stefan Monnier
2014-10-15 14:26       ` Reuben Thomas
2014-10-15 14:27         ` Reuben Thomas
2014-10-15 17:59         ` Stefan Monnier
2014-10-15 19:05           ` Reuben Thomas
2014-10-15 22:42             ` Stefan Monnier
2014-10-15 23:00               ` Reuben Thomas
2014-10-16  3:10                 ` Stefan Monnier
2014-10-15 14:26       ` Andreas Schwab
2014-10-15 17:57         ` Stefan Monnier
2014-10-15 20:57           ` Andreas Schwab
2014-10-15 22:44             ` Stefan Monnier
2014-10-15 22:54               ` Glenn Morris
2014-10-16  3:06                 ` Stefan Monnier
2014-10-16  7:13                   ` Andreas Schwab
2014-10-16 13:15                     ` Stefan Monnier
2014-10-16  2:01   ` Richard Stallman
2014-10-16  3:09     ` Stefan Monnier
2014-10-16 18:14       ` Richard Stallman
2014-10-16 20:17         ` Stefan Monnier
2016-11-08 17:51 ` bug#18716: Patch for this bug Reuben Thomas
2016-11-08 20:04   ` Eli Zaretskii
2016-11-08 22:16     ` Reuben Thomas
2016-11-09 19:36       ` Eli Zaretskii
2016-11-09 22:00         ` Reuben Thomas
2016-11-09 22:52           ` Drew Adams
2016-11-09 23:29             ` Reuben Thomas
2016-11-10 17:38           ` Eli Zaretskii
2016-11-26 17:54             ` Reuben Thomas
2016-11-26 18:29               ` Ken Brown
2016-11-28 21:32                 ` Reuben Thomas
2016-12-02  9:40                   ` Eli Zaretskii [this message]
2016-12-02 16:10                     ` Reuben Thomas
2016-12-02 16:16                       ` Eli Zaretskii
2016-12-02 16:31                         ` Reuben Thomas
2016-12-03  0:22 ` bug#18716: Reuben Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8360n2oej1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=18716@debbugs.gnu.org \
    --cc=rrt@sc3d.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).