From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26672: 25.2; Flyspell overlay conflicts with table.el Date: Sat, 29 Apr 2017 12:09:08 +0300 Message-ID: <8360hnmvgr.fsf@gnu.org> References: <83o9vgnbiv.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1493457012 5110 195.159.176.226 (29 Apr 2017 09:10:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 29 Apr 2017 09:10:12 +0000 (UTC) Cc: 26672@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 29 11:10:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4OOF-0001Fc-IB for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Apr 2017 11:10:07 +0200 Original-Received: from localhost ([::1]:40316 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4OOL-0003Ct-7z for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Apr 2017 05:10:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4OOE-0003BB-U5 for bug-gnu-emacs@gnu.org; Sat, 29 Apr 2017 05:10:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d4OOA-0001IS-S1 for bug-gnu-emacs@gnu.org; Sat, 29 Apr 2017 05:10:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47306) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d4OOA-0001IH-O8 for bug-gnu-emacs@gnu.org; Sat, 29 Apr 2017 05:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d4OOA-0000oV-FM for bug-gnu-emacs@gnu.org; Sat, 29 Apr 2017 05:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Apr 2017 09:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26672 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26672-submit@debbugs.gnu.org id=B26672.14934569923107 (code B ref 26672); Sat, 29 Apr 2017 09:10:02 +0000 Original-Received: (at 26672) by debbugs.gnu.org; 29 Apr 2017 09:09:52 +0000 Original-Received: from localhost ([127.0.0.1]:45505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4ONy-0000o2-PD for submit@debbugs.gnu.org; Sat, 29 Apr 2017 05:09:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4ONx-0000np-5P for 26672@debbugs.gnu.org; Sat, 29 Apr 2017 05:09:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d4ONn-00015E-RN for 26672@debbugs.gnu.org; Sat, 29 Apr 2017 05:09:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4ONn-000158-NU; Sat, 29 Apr 2017 05:09:39 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4647 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d4ONn-000787-0Z; Sat, 29 Apr 2017 05:09:39 -0400 In-reply-to: (message from Allen Li on Fri, 28 Apr 2017 21:19:38 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132093 Archived-At: > From: Allen Li > Date: Fri, 28 Apr 2017 21:19:38 -0700 > Cc: 26672@debbugs.gnu.org > > 1. emacs -Q > 2. M-x flyspell-mode > 3. M-x table-insert RET RET RET ... (the defaults are fine) > 4. apple M-b TAB (apple is spelled correctly, TAB works) > 5. asdf M-b TAB (wait for flyspell to mark the misspelling, TAB doesn't work) Thanks. Does the change below give good results? diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el index 0edf9b1..ecf729d 100644 --- a/lisp/textmodes/flyspell.el +++ b/lisp/textmodes/flyspell.el @@ -447,7 +447,9 @@ flyspell-prog-mode ;;* The minor mode declaration. */ ;;*---------------------------------------------------------------------*/ (defvar flyspell-mouse-map - (make-sparse-keymap) + (let ((map (make-sparse-keymap))) + (define-key map [mouse-2] 'flyspell-correct-word) + map) "Keymap for Flyspell to put on erroneous words.") (defvar flyspell-mode-map @@ -1759,6 +1761,9 @@ make-flyspell-overlay (overlay-put overlay 'flyspell-overlay t) (overlay-put overlay 'evaporate t) (overlay-put overlay 'help-echo "mouse-2: correct word at point") + ;; If misspelled text has a 'keymap' property, let that remain in + ;; effect for the bindings that flyspell-mouse-map doesn't override. + (set-keymap-parent flyspell-mouse-map (get-char-property beg 'keymap)) (overlay-put overlay 'keymap flyspell-mouse-map) (when (eq face 'flyspell-incorrect) (and (stringp flyspell-before-incorrect-word-string)