From: Eli Zaretskii <eliz@gnu.org>
To: yegortimoshenko@gmail.com
Cc: 27752@debbugs.gnu.org
Subject: bug#27752: Custom mode-line face + smart eshell triggers interesting freeze
Date: Tue, 18 Jul 2017 19:24:08 +0300 [thread overview]
Message-ID: <8360epd87r.fsf@gnu.org> (raw)
In-Reply-To: <837ez5d9fa.fsf@gnu.org> (message from Eli Zaretskii on Tue, 18 Jul 2017 18:58:01 +0300)
> Date: Tue, 18 Jul 2017 18:58:01 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 27752@debbugs.gnu.org
>
> > From: Yegor Timoshenko <yegortimoshenko@gmail.com>
> > Date: Tue, 18 Jul 2017 13:46:54 +0300
> >
> > Emacs config required to reproduce this bug:
> >
> > (custom-set-faces
> > '(mode-line ((t (:box 1)))))
> >
> > (require 'em-smart)
> > (add-hook 'eshell-mode-hook 'eshell-smart-initialize)
> >
> > Instructions:
> >
> > M-x eshell, M-x split-window-horizontally, type "find-file foo" in the eshell buffer and hit ENTER.
> > Emacs freezes, CPU consumption is around 100%.
>
> This happens because Eshell abuses window-scroll-functions. I'm
> working on a fix.
Should be fixed now.
eshell-smart-redisplay called pos-visible-in-window-p, which is not a
very "smart" thing to do from a function that runs in the middle of
redisplay: how can the caller expect to get a reliable result, if the
window is being scrolled, and no one yet knows what will be inside the
window when redisplay ends. And there are other atrocities in
eshell-smart-redisplay.
Emacs now tries to protect itself against that, so that it won't
infloop.
Btw, I think this is the same bug as 26980, it's just that there I
never could have a reproducer.
next prev parent reply other threads:[~2017-07-18 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 10:46 bug#27752: Custom mode-line face + smart eshell triggers interesting freeze Yegor Timoshenko
2017-07-18 13:40 ` Yegor Timoshenko
2017-07-18 15:58 ` Eli Zaretskii
2017-07-18 16:24 ` Eli Zaretskii [this message]
2017-07-19 2:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8360epd87r.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=27752@debbugs.gnu.org \
--cc=yegortimoshenko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).