From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30792: 26.0.91; improve docstring of with-help-window Date: Tue, 20 Mar 2018 14:28:00 +0200 Message-ID: <83605rlynj.fsf@gnu.org> References: <5AA7A52D.6060808@gmx.at> <83zi3brk6r.fsf@gnu.org> <5AA8D9E9.2090204@gmx.at> <83605yska4.fsf@gnu.org> <5AA980A5.5020707@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1521548830 28053 195.159.176.226 (20 Mar 2018 12:27:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Mar 2018 12:27:10 +0000 (UTC) Cc: 30792-done@debbugs.gnu.org To: Nick Helm Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 20 13:27:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyGM5-0007AL-U0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Mar 2018 13:27:06 +0100 Original-Received: from localhost ([::1]:48136 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyGO7-0004GF-9v for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Mar 2018 08:29:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyGO1-0004Fw-SP for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 08:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyGNy-0004ri-Pc for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 08:29:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34920) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyGNy-0004rT-KR for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 08:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eyGNy-0000AM-ER for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 08:29:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Mar 2018 12:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 30792 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 30792@debbugs.gnu.org, eliz@gnu.org, nick@tenpoint.co.nz Original-Received: via spool by 30792-done@debbugs.gnu.org id=D30792.1521548886559 (code D ref 30792); Tue, 20 Mar 2018 12:29:02 +0000 Original-Received: (at 30792-done) by debbugs.gnu.org; 20 Mar 2018 12:28:06 +0000 Original-Received: from localhost ([127.0.0.1]:42816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyGN4-00008x-2U for submit@debbugs.gnu.org; Tue, 20 Mar 2018 08:28:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyGN2-00008T-Lz for 30792-done@debbugs.gnu.org; Tue, 20 Mar 2018 08:28:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyGMw-0004Sr-Mb for 30792-done@debbugs.gnu.org; Tue, 20 Mar 2018 08:27:59 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyGMo-0004Q6-7S; Tue, 20 Mar 2018 08:27:50 -0400 Original-Received: from [176.228.60.248] (port=4229 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eyGMn-0002X7-J4; Tue, 20 Mar 2018 08:27:50 -0400 In-reply-to: (message from Nick Helm on Mon, 19 Mar 2018 00:19:03 +1300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144446 Archived-At: > From: Nick Helm > Cc: Eli Zaretskii , martin rudalics > Date: Mon, 19 Mar 2018 00:19:03 +1300 > > Two patches attached. Thanks, I pushed them to the emacs-26 branch. Note that they needed "some work", please try to make sure these minor nits are taken care of in your future contributions: . always mention the bug number in the commit log message . make sure the lines in the commit log message are shorter than 67 characters, so that they don't overflow a line when converted to a ChangeLog file . be sure to read the docs after renaming variables, because frequently additional changes are needed to make the result clear and/or palatable . it's better not to break a changeset into separate parts, unless really necessary, so that the result is a single commit on the mainline Keeping those rules will allow us to use "git am" instead of committing manually.