From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31446: 26.1; sql-interactive-mode buffer naming is broken Date: Fri, 18 May 2018 19:04:35 +0300 Message-ID: <83603lhrvw.fsf@gnu.org> References: <83d0xti993.fsf@gnu.org> <83bmddi2ad.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1526659393 28457 195.159.176.226 (18 May 2018 16:03:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 May 2018 16:03:13 +0000 (UTC) Cc: psainty@orcon.net.nz, 31446@debbugs.gnu.org To: Filipp Gunbin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 18 18:03:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJhqX-0007I9-09 for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 May 2018 18:03:09 +0200 Original-Received: from localhost ([::1]:39791 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJhsd-0007Nz-Th for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 May 2018 12:05:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJhsQ-0007MS-6y for bug-gnu-emacs@gnu.org; Fri, 18 May 2018 12:05:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJhsM-0003iG-Au for bug-gnu-emacs@gnu.org; Fri, 18 May 2018 12:05:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60313) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fJhsM-0003i9-7t for bug-gnu-emacs@gnu.org; Fri, 18 May 2018 12:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fJhsL-0005y8-Vm for bug-gnu-emacs@gnu.org; Fri, 18 May 2018 12:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 May 2018 16:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31446-submit@debbugs.gnu.org id=B31446.152665949822926 (code B ref 31446); Fri, 18 May 2018 16:05:01 +0000 Original-Received: (at 31446) by debbugs.gnu.org; 18 May 2018 16:04:58 +0000 Original-Received: from localhost ([127.0.0.1]:39977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJhsF-0005xg-Rz for submit@debbugs.gnu.org; Fri, 18 May 2018 12:04:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJhsE-0005xU-Ey for 31446@debbugs.gnu.org; Fri, 18 May 2018 12:04:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJhs6-0003YK-OS for 31446@debbugs.gnu.org; Fri, 18 May 2018 12:04:49 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJhs6-0003YE-KE; Fri, 18 May 2018 12:04:46 -0400 Original-Received: from [176.228.60.248] (port=4773 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fJhs5-0000Je-21; Fri, 18 May 2018 12:04:46 -0400 In-reply-to: (message from Filipp Gunbin on Fri, 18 May 2018 18:44:38 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146266 Archived-At: > From: Filipp Gunbin > Cc: psainty@orcon.net.nz, 31446@debbugs.gnu.org > Date: Fri, 18 May 2018 18:44:38 +0300 > > But `sql-comint' (called from `sql-comint-postgres' and the like) has > logic which prepares buffer name (adding those asterisks etc.) > > In `sql-product-interactive', `new-name', if set to '(4) from prefix, or > to some other value from argument, controls this: > > (if (and (not new-name) buf) > (pop-to-buffer buf) > > So if `new-name' is set, we shouldn't switch to existing buffer. I'm sorry, but I don't understand the issue you are alluding to. The bug I tried to fix was that the buffer got named incorrectly. Is that fixed by the patch? If it isn't, please tell why. If the patch does fix the bug, then the issues you mention are separate problems, because I don't think I changed the logic of which buffer is going to become the current. What am I missing?