From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: michael_heerdegen@web.de, radon.neon@gmail.com, 31692@debbugs.gnu.org
Subject: bug#31692: Emacs sometimes drops key events
Date: Thu, 07 Jun 2018 18:52:49 +0300 [thread overview]
Message-ID: <83602uwq3y.fsf@gnu.org> (raw)
In-Reply-To: <jwv1sdihb43.fsf-monnier+emacsbugs@gnu.org> (message from Stefan Monnier on Thu, 07 Jun 2018 11:30:58 -0400)
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: Michael Heerdegen <michael_heerdegen@web.de>, radon.neon@gmail.com,
> 31692@debbugs.gnu.org
> Date: Thu, 07 Jun 2018 11:30:58 -0400
>
> I don't understand the (throw 'throw-on-input t)
> (throw throw-on-input t) would make more sense, but in any case we're
> just about to exit that `catch` so throwing won't have any real effect.
I hoped the comment explained that, but evidently not.
> I think instead of (throw 'throw-on-input t) what is needed here is
>
> (setq quit-flag nil)
>
> which will also make the body return nil (rather than t like (throw
> throw-on-input t) would), which I believe is also the right thing.
I believe we need to return t here, because input did arrive. We
could indeed just return t instead of throwing, but that's not the
main issue for which I wanted your opinion.
next prev parent reply other threads:[~2018-06-07 15:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-03 2:21 bug#31692: Emacs sometimes drops key events Radon Rosborough
2018-06-03 2:36 ` Eli Zaretskii
2018-06-03 4:54 ` Radon Rosborough
2018-06-03 15:05 ` Eli Zaretskii
2018-06-03 19:23 ` Alan Third
2018-06-04 10:41 ` João Távora
2018-06-05 0:59 ` Michael Heerdegen
2018-06-05 2:37 ` Eli Zaretskii
2018-06-05 2:41 ` Radon Rosborough
2018-06-05 4:11 ` Eli Zaretskii
2018-06-05 21:40 ` Michael Heerdegen
2018-06-06 2:37 ` Eli Zaretskii
2018-06-06 2:58 ` Michael Heerdegen
2018-06-06 14:52 ` Eli Zaretskii
2018-06-06 23:12 ` Michael Heerdegen
2018-06-07 15:20 ` Eli Zaretskii
2018-06-06 14:45 ` Eli Zaretskii
2018-06-06 22:50 ` Michael Heerdegen
2018-06-07 15:20 ` Eli Zaretskii
2018-06-07 15:30 ` Stefan Monnier
2018-06-07 15:52 ` Eli Zaretskii [this message]
2018-06-07 18:44 ` Stefan Monnier
2018-06-08 22:17 ` Michael Heerdegen
2018-06-11 21:08 ` Michael Heerdegen
2018-06-12 2:27 ` Eli Zaretskii
2018-06-16 8:26 ` Eli Zaretskii
2018-06-16 8:28 ` Eli Zaretskii
2018-06-17 4:39 ` Michael Heerdegen
2018-07-05 19:07 ` Michael Heerdegen
2018-07-05 19:27 ` Eli Zaretskii
2018-07-06 17:43 ` Michael Heerdegen
2018-06-05 2:48 ` Michael Heerdegen
2018-06-05 4:13 ` Eli Zaretskii
2018-06-05 11:57 ` Noam Postavsky
2018-06-05 14:31 ` Eli Zaretskii
2018-06-05 21:39 ` Artur Malabarba
2018-06-06 14:39 ` Eli Zaretskii
2018-06-03 12:13 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83602uwq3y.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=31692@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@IRO.UMontreal.CA \
--cc=radon.neon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).